Folks,

In an attempt to create my own implementation of PageParameterEncoder and
PageParameters, I encountered the following problem with the API:

The interface 
INamedParameters<http://wicket.apache.org/apidocs/1.5/org/apache/wicket/request/mapper/parameter/INamedParameters.html>
defines
the method 
getAllNamed()<http://wicket.apache.org/apidocs/1.5/org/apache/wicket/request/mapper/parameter/INamedParameters.html#getAllNamed()>
that
returns a list of
NamedPairs<http://wicket.apache.org/apidocs/1.5/org/apache/wicket/request/mapper/parameter/PageParameters.NamedPair.html>
defined
as inner class of
PageParameters<http://wicket.apache.org/apidocs/1.5/org/apache/wicket/request/mapper/parameter/PageParameters.html>
 .

I believe that an interface shouldnt be referencing any element from an
implementation to be a true extensible interface.
A quick fix to this could be to convert NamedPair to a standard class and
make it extensible as well.

Thoughts?

-- 
Jorge Gallardo
----------------------------------------
jorgeagalla...@gmail.com

Reply via email to