sure, as long as INamedParameters#getAllNamed() still uses PageParameters#NamedPair which of course will not fix anything....
-igor On Wed, Sep 21, 2011 at 12:55 PM, Bruno Borges <bruno.bor...@gmail.com> wrote: > Well, it could be done in 1.5.x this way: > > PageParameters.NamedPairs extends INamedParameters.NamedPairs > > In 1.6 then PP.NP could be dropped. > > What about that? > > > *Bruno Borges* > (21) 7672-7099 > *www.brunoborges.com* > > > > On Wed, Sep 21, 2011 at 12:13 PM, Igor Vaynberg > <igor.vaynb...@gmail.com>wrote: > >> cant do in 1.5.x. make a ticket and schedule for 1.6.0 >> >> -igor >> >> >> On Wed, Sep 21, 2011 at 8:12 AM, Martin Grigorov <mgrigo...@apache.org> >> wrote: >> > On Wed, Sep 21, 2011 at 6:08 PM, Jorge Gallardo >> > <jorgeagalla...@gmail.com> wrote: >> >> Folks, >> >> >> >> In an attempt to create my own implementation of PageParameterEncoder >> and >> >> PageParameters, I encountered the following problem with the API: >> >> >> >> The interface INamedParameters< >> http://wicket.apache.org/apidocs/1.5/org/apache/wicket/request/mapper/parameter/INamedParameters.html >> > >> >> defines >> >> the method getAllNamed()< >> http://wicket.apache.org/apidocs/1.5/org/apache/wicket/request/mapper/parameter/INamedParameters.html#getAllNamed() >> > >> >> that >> >> returns a list of >> >> NamedPairs< >> http://wicket.apache.org/apidocs/1.5/org/apache/wicket/request/mapper/parameter/PageParameters.NamedPair.html >> > >> >> defined >> >> as inner class of >> >> PageParameters< >> http://wicket.apache.org/apidocs/1.5/org/apache/wicket/request/mapper/parameter/PageParameters.html >> > >> >> . >> >> >> >> I believe that an interface shouldnt be referencing any element from an >> >> implementation to be a true extensible interface. >> >> A quick fix to this could be to convert NamedPair to a standard class >> and >> >> make it extensible as well. >> > Or make it INamedParameters.NamedPair >> >> >> >> Thoughts? >> >> >> >> -- >> >> Jorge Gallardo >> >> ---------------------------------------- >> >> jorgeagalla...@gmail.com >> >> >> > >> > >> > >> > -- >> > Martin Grigorov >> > jWeekend >> > Training, Consulting, Development >> > http://jWeekend.com >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >> > For additional commands, e-mail: users-h...@wicket.apache.org >> > >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >> For additional commands, e-mail: users-h...@wicket.apache.org >> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
