re-ordered with r1174198. On Thu, Sep 22, 2011 at 6:19 PM, Martin Grigorov <mgrigo...@apache.org> wrote: > On Thu, Sep 22, 2011 at 6:11 PM, Ian Marshall <ianmarshall...@gmail.com> > wrote: >> In the 1.5.0 documentation for org.apache.wicket.model.StringResourceModel, >> one constructor is >> >> public StringResourceModel(String resourceKey, >> Component component, >> IModel<?> model, >> String defaultValue, >> Object... parameters) >> >> >> EXTRACT FROM EXISTING DOCUMENTATION >> ... >> Parameters: >> resourceKey - The resource key for this string resource >> component - The component that the resource is relative to >> model - The model to use for property substitutions >> parameters - The parameters to substitute using a Java MessageFormat >> object >> defaultValue - The default value if the resource key is not found. >> >> >> COMMENT >> All I am saying is that the ordering of the "Parameters" section above might >> want to be tweaked to match the order of the constructor's parameters - >> particularly since the last parameter is now vararg in 1.5. >> >> (I did say "Minor typo" - but I guess that this issue is not a typo at all - >> just a very minor tweak.) > > You mean the order of the @param's is not matching ? > I don't think this is a problem for bin/javadoc >> >> >> >> Martin Grigorov-4 wrote: >>> >>> you can paste a patch here >>> I'm not sure that I understand you >>> >>> On Thu, Sep 22, 2011 at 5:15 PM, Ian Marshall >>> <ianmarshall...@gmail.com> wrote: >>>> Hello there, >>>> >>>> I believe that I have spotted a minor typo in the 1.5.0 Javadocs for >>>> org.apache.wicket.model.StringResourceModel whilst fettling my app for >>>> 1.5. >>>> >>>> For the documentation for the constructor >>>> >>>> StringResourceModel(String resourceKey, Component component, IModel<?> >>>> model, String defaultValue, Object... parameters) >>>> >>>> the "Parameters" section is unchanged from 1.4 and does not reflect the >>>> modified method signature. >>>> >>>> I don't think that I can change this so I submit this post for comment. >>>> >>>> Ian >>>> >>>> -- >>>> View this message in context: >>>> http://apache-wicket.1842946.n4.nabble.com/Minor-typo-in-the-1-5-0-Javadocs-for-StringResourceModel-tp3833555p3833555.html >>>> Sent from the Users forum mailing list archive at Nabble.com. >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >>>> For additional commands, e-mail: users-h...@wicket.apache.org >>>> >>>> >>> >>> >>> >>> -- >>> Martin Grigorov >>> jWeekend >>> Training, Consulting, Development >>> http://jWeekend.com >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >>> For additional commands, e-mail: users-h...@wicket.apache.org >>> >> >> -- >> View this message in context: >> http://apache-wicket.1842946.n4.nabble.com/Minor-typo-in-the-1-5-0-Javadocs-for-StringResourceModel-tp3833555p3833702.html >> Sent from the Users forum mailing list archive at Nabble.com. >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org >> For additional commands, e-mail: users-h...@wicket.apache.org >> >> > > > > -- > Martin Grigorov > jWeekend > Training, Consulting, Development > http://jWeekend.com >
-- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
