Done! Please confirm that this is enough for now.
On Fri, Nov 2, 2012 at 7:01 PM, Sebastien <seb...@gmail.com> wrote: > Great! Thanks Martin! > > On Fri, Nov 2, 2012 at 5:01 PM, Martin Grigorov <mgrigo...@apache.org>wrote: > >> I'll take care. >> >> On Fri, Nov 2, 2012 at 5:59 PM, Sebastien <seb...@gmail.com> wrote: >> > Hi Alec, >> > >> > If Sven or Martin agree with this solution for 1.5.9 & 6.3.0, I can >> attach >> > the patch(es) to the opened ticket if needed. (but to replace a word by >> > another, I am not sure my support will help that much! :) ) >> > >> > I also think that we can keep this AttributeAppender even with the >> changes >> > to be done for wicket7 (with the Martin's suggestion for instance). At >> > least I do not see yet any potential issue / unexpected behavior that can >> > happens, and we keep the advantage it provides... >> > >> > Best regards, >> > Sebastien. >> > >> > On Fri, Nov 2, 2012 at 4:21 PM, Alec Swan <alecs...@gmail.com> wrote: >> > >> >> Sebastien, thanks for reviewing and approving the proposal. So, what >> >> do we need to do to make it in 1.5.9? Or did you already check it in >> >> there? >> >> >> >> Thanks, >> >> >> >> Alec >> >> >> >> On Thu, Nov 1, 2012 at 6:04 PM, Sebastien <seb...@gmail.com> wrote: >> >> > Hi Alec, >> >> > >> >> > Thanks for having taking time to write the code snippet bellow, I >> better >> >> > understand your idea!.. >> >> > I did not realized you didn't want to use getCssClass, but I think it >> is >> >> > good solution anyway! It is easy for the user to replace >> >> > message.isInfo() ? ".my-ui-info" : ".my-ui-error" >> >> > by its custom method: getMessageCssClass(message.getLevel()) or >> something >> >> > equivalent as we spoke before, so that's fine for me. Well done! >> >> > >> >> > Thanks again & best regards, >> >> > Sebastien. >> >> > >> -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
