Hi Alec,
Please use the mailing lists. Don't write private messages.
On Wed, Nov 7, 2012 at 8:02 PM, Alec Swan <alecs...@gmail.com> wrote:
> I verified that the change is in master branch, but not in
> wicket-1.5.x branch. What is wicket-1.5.x branch used for?
>
martin@martin-laptop:~/git/apache/wicket-1.5.x(wicket-1.5.x=)$ git log
--grep=WICKET-4831
commit d7e019152df0756d307d8136dd94fcdb819823a6
Author: svenmeier <svenme...@apache.org>
Date: Fri Nov 2 21:31:46 2012 +0100
WICKET-4831 removed class attribute from markup
commit afec3a61ccd63e833586be33867eb873a721a941
Author: Martin Tzvetanov Grigorov <mgrigo...@apache.org>
Date: Fri Nov 2 19:01:09 2012 +0200
WICKET-4831 Append the feedback message CSS class instead of overriding
it
>
> On Tue, Nov 6, 2012 at 11:44 PM, Martin Grigorov <mgrigo...@apache.org>
> wrote:
> > The ticket says that the improvement is in 1.5.9, no ?
> >
> >
> > On Wed, Nov 7, 2012 at 1:45 AM, Alec Swan <alecs...@gmail.com> wrote:
> >>
> >> Martin, could you please merge your changes to 1.5.9 branch?
> >>
> >> Thanks,
> >>
> >> Alec
> >>
> >>
> >> ---------- Forwarded message ----------
> >> From: Alec Swan <alecs...@gmail.com>
> >> Date: Fri, Nov 2, 2012 at 1:48 PM
> >> Subject: Re: Custom CSS for Feedback message is broken in 1.5
> >> To: users@wicket.apache.org
> >>
> >>
> >> I don't see 1.5.9 branch either and I don't see the changes in 1.5.x
> >> branch. Martin, where did you check your changes in?
> >>
> >> Thanks,
> >>
> >> Alec
> >>
> >> On Fri, Nov 2, 2012 at 12:56 PM, Sebastien <seb...@gmail.com> wrote:
> >> > Hi Martin,
> >> >
> >> > Tested & approved! Works like a charm...
> >> >
> >> > I tested upon master branch (6.3.0-SNAPSHOT), because I do not see
> were
> >> > wicket-1.5.9 branch is... But I guess it behaves exactly the same.
> >> > Just a little note; on the version I pulled I still have
> >> > class="errorlevel"
> >> > in the associated markup (Sven's added a comment in the ticket about
> >> > this,
> >> > I don't know if you had it)...
> >> >
> >> > Thanks again & best regards,
> >> > Sebastien.
> >> >
> >> > On Fri, Nov 2, 2012 at 6:08 PM, Martin Grigorov
> >> > <mgrigo...@apache.org>wrote:
> >> >
> >> >> Done!
> >> >>
> >> >> Please confirm that this is enough for now.
> >> >>
> >> >> On Fri, Nov 2, 2012 at 7:01 PM, Sebastien <seb...@gmail.com> wrote:
> >> >> > Great! Thanks Martin!
> >> >> >
> >> >> > On Fri, Nov 2, 2012 at 5:01 PM, Martin Grigorov <
> mgrigo...@apache.org
> >> >> >wrote:
> >> >> >
> >> >> >> I'll take care.
> >> >> >>
> >> >> >> On Fri, Nov 2, 2012 at 5:59 PM, Sebastien <seb...@gmail.com>
> wrote:
> >> >> >> > Hi Alec,
> >> >> >> >
> >> >> >> > If Sven or Martin agree with this solution for 1.5.9 & 6.3.0, I
> >> >> >> > can
> >> >> >> attach
> >> >> >> > the patch(es) to the opened ticket if needed. (but to replace a
> >> >> >> > word
> >> >> by
> >> >> >> > another, I am not sure my support will help that much! :) )
> >> >> >> >
> >> >> >> > I also think that we can keep this AttributeAppender even with
> the
> >> >> >> changes
> >> >> >> > to be done for wicket7 (with the Martin's suggestion for
> >> >> >> > instance). At
> >> >> >> > least I do not see yet any potential issue / unexpected behavior
> >> >> >> > that
> >> >> can
> >> >> >> > happens, and we keep the advantage it provides...
> >> >> >> >
> >> >> >> > Best regards,
> >> >> >> > Sebastien.
> >> >> >> >
> >> >> >> > On Fri, Nov 2, 2012 at 4:21 PM, Alec Swan <alecs...@gmail.com>
> >> >> >> > wrote:
> >> >> >> >
> >> >> >> >> Sebastien, thanks for reviewing and approving the proposal. So,
> >> >> >> >> what
> >> >> >> >> do we need to do to make it in 1.5.9? Or did you already check
> it
> >> >> >> >> in
> >> >> >> >> there?
> >> >> >> >>
> >> >> >> >> Thanks,
> >> >> >> >>
> >> >> >> >> Alec
> >> >> >> >>
> >> >> >> >> On Thu, Nov 1, 2012 at 6:04 PM, Sebastien <seb...@gmail.com>
> >> >> >> >> wrote:
> >> >> >> >> > Hi Alec,
> >> >> >> >> >
> >> >> >> >> > Thanks for having taking time to write the code snippet
> bellow,
> >> >> >> >> > I
> >> >> >> better
> >> >> >> >> > understand your idea!..
> >> >> >> >> > I did not realized you didn't want to use getCssClass, but I
> >> >> >> >> > think
> >> >> it
> >> >> >> is
> >> >> >> >> > good solution anyway! It is easy for the user to replace
> >> >> >> >> > message.isInfo() ? ".my-ui-info" : ".my-ui-error"
> >> >> >> >> > by its custom method: getMessageCssClass(message.getLevel())
> or
> >> >> >> something
> >> >> >> >> > equivalent as we spoke before, so that's fine for me. Well
> >> >> >> >> > done!
> >> >> >> >> >
> >> >> >> >> > Thanks again & best regards,
> >> >> >> >> > Sebastien.
> >> >> >> >> >
> >> >> >>
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> Martin Grigorov
> >> >> jWeekend
> >> >> Training, Consulting, Development
> >> >> http://jWeekend.com
> >> >>
> >> >> ---------------------------------------------------------------------
> >> >> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> >> >> For additional commands, e-mail: users-h...@wicket.apache.org
> >> >>
> >> >>
> >
> >
> >
> >
> > --
> > Martin Grigorov
> > jWeekend
> > Training, Consulting, Development
> > http://jWeekend.com
> >
>
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com <http://jweekend.com/>
