Just pushed a hack that solves the problem. Pull and try again.
On Mon, Dec 3, 2012 at 1:47 AM, Chris Colman <[email protected]>wrote: > Bingo! - it's the difference between *nix and Windows. When I change the > forward slashes to backslashes in the clirr ignored section's > <className> element it works - for Windows at least!! There's a good > chance that backslashes will probably break for *nix but even though I > have a machine with Linux available I don't have any build environments > set up on it yet. > > <ignored> > <difference> > > <className>org\apache\wicket\feedback\FeedbackCollector</className> > <method>*</method> > <differenceType>7014</differenceType> > </difference> > </ignored> > > I tried replacing / with . but that failed also. > > It seems like clirr has not been written in a 'directory separator' > agnostic way. Which is a pity as the most recent release seems to be in > 2005 - so maybe the clirr devs aren't as active as with other projects. > > >-----Original Message----- > >From: Igor Vaynberg [mailto:[email protected]] > >Sent: Monday, 3 December 2012 8:39 AM > >To: [email protected] > >Subject: Re: master branch compiler error in core? > > > >im on osx > > > >-igor > > > >On Sun, Dec 2, 2012 at 4:37 AM, Martin Grigorov <[email protected]> > >wrote: > >> I use Ubuntu 12. > >> BuildBot (the CI) is some Unix too ( > >> http://ci.apache.org/builders/wicket-master). > >> I cannot test builds on Windows here. > >> > >> > >> On Sun, Dec 2, 2012 at 1:29 PM, Chris Colman > >> <[email protected]>wrote: > >> > >>> I'm still having the problem. > >>> > >>> I can see the clirr exclusions Igor added and they seem fine > according > >>> to the (vary sparse) Clirr doco. > >>> > >>> What platform are you and Igor building on? I'm building on: > >>> > >>> Win XP > >>> Java 1.6.0_31 > >>> 4GB RAM > >>> > >>> >-----Original Message----- > >>> >From: Martin Grigorov [mailto:[email protected]] > >>> >Sent: Friday, 30 November 2012 11:52 PM > >>> >To: [email protected] > >>> >Subject: Re: master branch compiler error in core? > >>> > > >>> >No errors here. > >>> >Igor added an exclusion in parent pom.xml for this change. > >>> > > >>> >https://git-wip- > >>> > >us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commitdiff;h=c3d4744 > >>> 8d1b > >>> >f5b5d0e8207bb8c0cf605cef8c18c > >>> > > >>> > > >>> >On Fri, Nov 30, 2012 at 1:36 PM, Chris Colman > >>> ><[email protected]>wrote: > >>> > > >>> >> I've just updated the master branch and I get the following build > >>> >> errors: > >>> >> > >>> >> [INFO] --- clirr-maven-plugin:2.5:check (clirr-check) @ > wicket-core > >>> --- > >>> >> [INFO] Comparing to version: 6.0.0 > >>> >> [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method > 'public > >>> >> java.util.List collect()' is now final > >>> >> [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method > 'public > >>> >> java.util.List > >>> >> collect(org.apache.wicket.feedback.IFeedbackMessageFilter)' is > now > >>> final > >>> >> [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method > 'public > >>> >> org.apache.wicket.feedback.FeedbackCollector > >>> setIncludeSession(boolean)' > >>> >> is now final > >>> >> [ERROR] org.apache.wicket.feedback.FeedbackCollector: Method > 'public > >>> >> org.apache.wicket.feedback.FeedbackCollector > setRecursive(boolean)' > >>> is > >>> >> now final > >>> >> [INFO] > >>> >> > >>> > ------------------------------------------------------------------------ > >>> >> > >>> >> Am I doing something wrong or is there an error in the latest > source? > >>> >> > >>> > > >>> > > >>> > > >>> >-- > >>> >Martin Grigorov > >>> >jWeekend > >>> >Training, Consulting, Development > >>> >http://jWeekend.com <http://jweekend.com/> > >>> > >>> > --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: [email protected] > >>> For additional commands, e-mail: [email protected] > >>> > >>> > >> > >> > >> -- > >> Martin Grigorov > >> jWeekend > >> Training, Consulting, Development > >> http://jWeekend.com <http://jweekend.com/> > > > >--------------------------------------------------------------------- > >To unsubscribe, e-mail: [email protected] > >For additional commands, e-mail: [email protected] > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com <http://jweekend.com/>
