I was suggesting to do both of them. Please file a ticket in JIRA and I'll implement it. Or attach a patch/send a pull request if you have the time :-) Thanks!
Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Oct 22, 2014 at 3:08 PM, Roman Grigoriadi < [email protected]> wrote: > First approach will be configurable per form, while second only per > /MultipartServletWebRequestImpl/. For setting fileSizeMax by second > approach > you will have also to override > > /org.apache.wicket.protocol.http.servlet.ServletWebRequest#newMultipartWebRequest(...)/. > On the other hand, second approach will expose FileUpload for custom > configuration/implementation, it feels more flexible, for example I can't > see where /FileUploadBase#setProgressListener(..)/ can be called in similar > manner to setFileSizeMax(). > > I would go with first option due to simplicity and configuration /per > form/, > or with both for more flexibility. > > Thank you Martin for your time and suggestion. > > > Martin Grigorov-4 wrote > > I see two improvements here: > > 1) add Form#fileSizeMax and pass it to MultipartServletWebRequest > > 2) add MultipartServletWebRequestImpl#newFileUpload(FileItemFactory) that > > applications can override if they need to set some more custom settings > > > > What do you think ? > > > > -- > View this message in context: > http://apache-wicket.1842946.n4.nabble.com/org-apache-wicket-util-upload-FileUploadBase-fileSizeMax-tp4668001p4668037.html > Sent from the Users forum mailing list archive at Nabble.com. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
