Merged! Seems to work as expected in our application Thanks for the fix Martin!
On Wed, Nov 26, 2014 at 10:20 AM, Maxim Solodovnik <solomax...@gmail.com> wrote: > Thanks a lot! > I'll backport! > > On Wed, Nov 26, 2014 at 1:34 AM, Martin Grigorov <mgrigo...@apache.org> > wrote: > >> Fixed with >> >> https://github.com/wicketstuff/core/commit/b7e5b68b858336d85958663204166bd0852b43dd >> Hopefully all other use cases are still covered. >> >> I just noticed that there is >> >> https://github.com/wicketstuff/core/tree/wicket-6.x/jdk-1.6-parent/select2-parent >> (i.e. Wicket 6.x version). >> It would be good if someone backports the improvements from master branch >> to wicket-6.x: >> >> https://github.com/wicketstuff/core/commits/master/jdk-1.7-parent/select2-parent >> It seems Igor has been active last month at >> https://github.com/ivaynberg/wicket-select2/ and merged few PRs. I've >> ported them to WicketStuff 7.x but not to 6.x. >> >> Martin Grigorov >> Wicket Training and Consulting >> https://twitter.com/mtgrigorov >> >> On Tue, Nov 25, 2014 at 8:48 PM, Martin Grigorov <mgrigo...@apache.org> >> wrote: >> >> > Hi Maxim, >> > >> > The change has been introduced in Wicket-Select2 with >> > https://github.com/ivaynberg/wicket-select2/issues/29 >> > I'll see how to fix it now. >> > >> > Martin Grigorov >> > Wicket Training and Consulting >> > https://twitter.com/mtgrigorov >> > >> > On Wed, Nov 12, 2014 at 12:11 PM, Martin Grigorov <mgrigo...@apache.org >> > >> > wrote: >> > >> >> It is in my TODO list... >> >> >> >> Martin Grigorov >> >> Wicket Training and Consulting >> >> https://twitter.com/mtgrigorov >> >> >> >> On Tue, Nov 11, 2014 at 6:29 PM, Maxim Solodovnik < >> solomax...@gmail.com> >> >> wrote: >> >> >> >>> Hello Martin, >> >>> >> >>> I know you are busy man ..., but, were you able to take a look at this >> >>> issue? :) >> >>> >> >>> On 22 October 2014 11:23, Maxim Solodovnik <solomax...@gmail.com> >> wrote: >> >>> >> >>> > It seems like script generated in renderInitializationScript should >> be >> >>> > added to AjaxRequestTarget on every Ajax update ... >> >>> > >> >>> > On 21 October 2014 17:09, Maxim Solodovnik <solomax...@gmail.com> >> >>> wrote: >> >>> > >> >>> >> Here it is: >> >>> >> https://github.com/solomax/WicketSelect2Clear >> >>> >> >> >>> >> somehow in this example nothing works as expected :( >> >>> >> I tried 2 different approaches, correct new value arrives to the >> page >> >>> >> (according to "wicket debug") but select2 is not being updated :( >> >>> >> >> >>> >> On 21 October 2014 13:23, Martin Grigorov <mgrigo...@apache.org> >> >>> wrote: >> >>> >> >> >>> >>> Hi Maxim, >> >>> >>> >> >>> >>> Please prepare a quickstart at GitHub and I'll take a look. >> >>> >>> >> >>> >>> Martin Grigorov >> >>> >>> Wicket Training and Consulting >> >>> >>> https://twitter.com/mtgrigorov >> >>> >>> >> >>> >>> On Fri, Oct 17, 2014 at 5:42 PM, Maxim Solodovnik < >> >>> solomax...@gmail.com> >> >>> >>> wrote: >> >>> >>> >> >>> >>> > Martin, >> >>> >>> > >> >>> >>> > I have forked select2, unfortunately I'm still not sure how to >> fix >> >>> the >> >>> >>> > issue :( >> >>> >>> > "Clean link" is added to the form and select data is being >> restored >> >>> >>> from >> >>> >>> > requestParameters :( >> >>> >>> > >> >>> >>> > On 13 October 2014 19:06, Martin Grigorov <mgrigo...@apache.org >> > >> >>> >>> wrote: >> >>> >>> > >> >>> >>> > > Maxim, >> >>> >>> > > >> >>> >>> > > Feel free to fork it! I.e. move it to WicketStuff. >> >>> >>> > > >> >>> >>> > > Martin Grigorov >> >>> >>> > > Wicket Training and Consulting >> >>> >>> > > https://twitter.com/mtgrigorov >> >>> >>> > > >> >>> >>> > > On Thu, Oct 9, 2014 at 8:53 PM, Maxim Solodovnik < >> >>> >>> solomax...@gmail.com> >> >>> >>> > > wrote: >> >>> >>> > > >> >>> >>> > > > Additionally select2 seems to need to be forked to >> wicketstuff >> >>> to >> >>> >>> be >> >>> >>> > > fixed, >> >>> >>> > > > should I do this? >> >>> >>> > > > >> >>> >>> > > > On 10 October 2014 00:49, Maxim Solodovnik < >> >>> solomax...@gmail.com> >> >>> >>> > wrote: >> >>> >>> > > > >> >>> >>> > > > > @Paul, @Martin >> >>> >>> > > > > >> >>> >>> > > > > Select2Choice sets back its value >> >>> >>> > > > > to >> getWebRequest().getRequestParameters().getParameterNames() >> >>> >>> > > > > in renderInitializationScript method [1] >> >>> >>> > > > > It seems like JS code like: $("#country1").select2("data", >> >>> >>> null); can >> >>> >>> > > be >> >>> >>> > > > > executed on clear input, but this seems to be workaround >> >>> >>> > > > > >> >>> >>> > > > > I'm not sure why [1] method is used to get value, maybe >> you >> >>> can >> >>> >>> > suggest >> >>> >>> > > > > correct way of fixing this? >> >>> >>> > > > > >> >>> >>> > > > > >> >>> >>> > > > > [1] >> >>> >>> > > > > >> >>> >>> > > > >> >>> >>> > > >> >>> >>> > >> >>> >>> >> >>> >> https://github.com/ivaynberg/wicket-select2/blob/master/wicket-select2/src/main/java/com/vaynberg/wicket/select2/Select2Choice.java#L62 >> >>> >>> > > > > >> >>> >>> > > > > On 9 October 2014 16:39, MadasamySankarapandian < >> >>> >>> > > madas...@mcruncher.com> >> >>> >>> > > > > wrote: >> >>> >>> > > > > >> >>> >>> > > > >> Thanks Maxim Solodovnik. >> >>> >>> > > > >> >> >>> >>> > > > >> On Thu, Oct 9, 2014 at 12:33 PM, Maxim Solodovnik < >> >>> >>> > > solomax...@gmail.com >> >>> >>> > > > > >> >>> >>> > > > >> wrote: >> >>> >>> > > > >> >> >>> >>> > > > >> > I also noticed this issue in our project, >> >>> >>> > > > >> > Will try to take a look at it >> >>> >>> > > > >> > >> >>> >>> > > > >> > On 9 October 2014 07:33, MadasamySankarapandian < >> >>> >>> > > > madas...@mcruncher.com >> >>> >>> > > > >> > >> >>> >>> > > > >> > wrote: >> >>> >>> > > > >> > >> >>> >>> > > > >> > > Thankyou very much for yours reply. >> >>> >>> > > > >> > > >> >>> >>> > > > >> > > I call formComponent.clearInput() in my >> ClearFormVisitor >> >>> >>> class. >> >>> >>> > > But >> >>> >>> > > > It >> >>> >>> > > > >> > does >> >>> >>> > > > >> > > not work. >> >>> >>> > > > >> > > I have created issue-96 >> >>> >>> > > > >> > > < >> https://github.com/ivaynberg/wicket-select2/issues/96> >> >>> in >> >>> >>> > > > >> > wicket-select2 >> >>> >>> > > > >> > > project. >> >>> >>> > > > >> > > >> >>> >>> > > > >> > > >> >>> >>> > > > >> > > >> >>> >>> > > > >> > > >> >>> >>> > > > >> > > >> >>> >>> > > > >> > > >> >>> >>> > > > >> > > On Wed, Oct 8, 2014 at 12:13 AM, Maxim Solodovnik < >> >>> >>> > > > >> solomax...@gmail.com> >> >>> >>> > > > >> > > wrote: >> >>> >>> > > > >> > > >> >>> >>> > > > >> > > > Done, thanks for pointing this out >> >>> >>> > > > >> > > > >> >>> >>> > > > >> > > > On 7 October 2014 23:08, Paul Bors <p...@bors.ws> >> >>> wrote: >> >>> >>> > > > >> > > > >> >>> >>> > > > >> > > > > Can you update this issue then? >> >>> >>> > > > >> > > > > >> >>> >>> > > > >> > > > > >> >>> https://github.com/ivaynberg/wicket-select2/issues/93 >> >>> >>> > > > >> > > > > >> >>> >>> > > > >> > > > > On Tue, Oct 7, 2014 at 12:00 PM, Maxim >> Solodovnik < >> >>> >>> > > > >> > > solomax...@gmail.com> >> >>> >>> > > > >> > > > > wrote: >> >>> >>> > > > >> > > > > >> >>> >>> > > > >> > > > > > we recently moved this component to >> wicketstuff: >> >>> >>> > > > >> > > > > > >> >>> >>> > > > >> > > > > > >> >>> >>> > > > >> > > > > >> >>> >>> > > > >> > > > >> >>> >>> > > > >> > > >> >>> >>> > > > >> > >> >>> >>> > > > >> >> >>> >>> > > > >> >>> >>> > > >> >>> >>> > >> >>> >>> >> >>> >> https://github.com/wicketstuff/core/tree/master/jdk-1.7-parent/select2-parent >> >>> >>> > > > >> > > > > > >> >>> >>> > > > >> > > > > > to get Wicket7 compatible version >> >>> >>> > > > >> > > > > > >> >>> >>> > > > >> > > > > > >> >>> >>> > > > >> > > > > > On 7 October 2014 22:56, Paul Bors < >> p...@bors.ws> >> >>> >>> wrote: >> >>> >>> > > > >> > > > > > >> >>> >>> > > > >> > > > > > > You can also ask the developer via: >> >>> >>> > > > >> > > > > > > >> >>> https://github.com/ivaynberg/wicket-select2/issues >> >>> >>> > > > >> > > > > > > >> >>> >>> > > > >> > > > > > > You should probably take a look over the open >> >>> >>> issues so >> >>> >>> > > that >> >>> >>> > > > >> you >> >>> >>> > > > >> > > are >> >>> >>> > > > >> > > > > > > familiar with that other developers faced. >> Maybe >> >>> >>> one of >> >>> >>> > > > those >> >>> >>> > > > >> > > issues >> >>> >>> > > > >> > > > > > might >> >>> >>> > > > >> > > > > > > be a road block for you? >> >>> >>> > > > >> > > > > > > >> >>> >>> > > > >> > > > > > > Although you will get a faster reply from >> Igor >> >>> or >> >>> >>> > another >> >>> >>> > > > >> Wicket >> >>> >>> > > > >> > > > > > developer >> >>> >>> > > > >> > > > > > > via this list :) >> >>> >>> > > > >> > > > > > > >> >>> >>> > > > >> > > > > > > On Tue, Oct 7, 2014 at 4:23 AM, Martin >> Grigorov >> >>> < >> >>> >>> > > > >> > > > mgrigo...@apache.org> >> >>> >>> > > > >> > > > > > > wrote: >> >>> >>> > > > >> > > > > > > >> >>> >>> > > > >> > > > > > > > Hi, >> >>> >>> > > > >> > > > > > > > >> >>> >>> > > > >> > > > > > > > You should call formComponent.clearInput() >> >>> too. >> >>> >>> > > > >> > > > > > > > >> >>> >>> > > > >> > > > > > > > Martin Grigorov >> >>> >>> > > > >> > > > > > > > Wicket Training and Consulting >> >>> >>> > > > >> > > > > > > > https://twitter.com/mtgrigorov >> >>> >>> > > > >> > > > > > > > >> >>> >>> > > > >> > > > > > > > On Tue, Oct 7, 2014 at 9:13 AM, >> >>> >>> > MadasamySankarapandian < >> >>> >>> > > > >> > > > > > > > madas...@mcruncher.com> wrote: >> >>> >>> > > > >> > > > > > > > >> >>> >>> > > > >> > > > > > > > > >> >>> >>> > > > >> > > > > > > > > This is regarding wicket-select2 >> project. I >> >>> >>> could >> >>> >>> > not >> >>> >>> > > > find >> >>> >>> > > > >> > any >> >>> >>> > > > >> > > > > > mailing >> >>> >>> > > > >> > > > > > > > > list for this project. That is why >> sending >> >>> here. >> >>> >>> > > Please >> >>> >>> > > > >> some >> >>> >>> > > > >> > > one >> >>> >>> > > > >> > > > > help >> >>> >>> > > > >> > > > > > > me. >> >>> >>> > > > >> > > > > > > > > >> >>> >>> > > > >> > > > > > > > > I have created clear link to clear the >> form >> >>> >>> input >> >>> >>> > > > values. >> >>> >>> > > > >> > After >> >>> >>> > > > >> > > > > click >> >>> >>> > > > >> > > > > > > the >> >>> >>> > > > >> > > > > > > > > clear link, all components values are >> >>> cleared >> >>> >>> > except >> >>> >>> > > > >> > > > Select2Choice >> >>> >>> > > > >> > > > > > > > > component. >> >>> >>> > > > >> > > > > > > > > >> >>> >>> > > > >> > > > > > > > > Here with attached quickstart to recreate >> >>> this >> >>> >>> > > problem. >> >>> >>> > > > >> > > > > > > > > >> >>> >>> > > > >> > > > > > > > > Follow below steps to recreate this >> problem >> >>> >>> > > > >> > > > > > > > > >> >>> >>> > > > >> > > > > > > > > * Download attachment and extract it. >> >>> >>> > > > >> > > > > > > > > * cd select2-quickstart. >> >>> >>> > > > >> > > > > > > > > * Then execute mvn clean package >> jetty:run >> >>> >>> > > > >> > > > > > > > > * Type localhost:8080 in browser >> >>> >>> > > > >> > > > > > > > > * Give the input to name and country >> field. >> >>> >>> > > > >> > > > > > > > > * Click clear link >> >>> >>> > > > >> > > > > > > > > >> >>> >>> > > > >> > > > > > > > > Now name(*TextField*) field value is >> >>> cleared and >> >>> >>> > > > >> > > > > > > country(*Select2Choice*) >> >>> >>> > > > >> > > > > > > > > field value is not cleared. >> >>> >>> > > > >> > > > > > > > > >> >>> >>> > > > >> > > > > > > > > >> >>> >>> > > > >> > > > > > > > > >> >>> >>> > > > >> > > > > > > > > -- >> >>> >>> > > > >> > > > > > > > > Thanks and regards >> >>> >>> > > > >> > > > > > > > > Madasamy >> >>> >>> > > > >> > > > > > > > > >> >>> >>> > > > >> > > > > > > > > >> >>> >>> > > > >> > > > > > > > > >> >>> >>> > > > >> > > > > >> >>> >>> > > > >> >> >>> >>> > >> >>> --------------------------------------------------------------------- >> >>> >>> > > > >> > > > > > > > > To unsubscribe, e-mail: >> >>> >>> > > > >> users-unsubscr...@wicket.apache.org >> >>> >>> > > > >> > > > > > > > > For additional commands, e-mail: >> >>> >>> > > > >> > users-h...@wicket.apache.org >> >>> >>> > > > >> > > > > > > > > >> >>> >>> > > > >> > > > > > > > >> >>> >>> > > > >> > > > > > > >> >>> >>> > > > >> > > > > > >> >>> >>> > > > >> > > > > > >> >>> >>> > > > >> > > > > > >> >>> >>> > > > >> > > > > > -- >> >>> >>> > > > >> > > > > > WBR >> >>> >>> > > > >> > > > > > Maxim aka solomax >> >>> >>> > > > >> > > > > > >> >>> >>> > > > >> > > > > >> >>> >>> > > > >> > > > >> >>> >>> > > > >> > > > >> >>> >>> > > > >> > > > >> >>> >>> > > > >> > > > -- >> >>> >>> > > > >> > > > WBR >> >>> >>> > > > >> > > > Maxim aka solomax >> >>> >>> > > > >> > > > >> >>> >>> > > > >> > > >> >>> >>> > > > >> > > >> >>> >>> > > > >> > > >> >>> >>> > > > >> > > -- >> >>> >>> > > > >> > > Thanks and regards >> >>> >>> > > > >> > > Madasamy >> >>> >>> > > > >> > > >> >>> >>> > > > >> > >> >>> >>> > > > >> > >> >>> >>> > > > >> > >> >>> >>> > > > >> > -- >> >>> >>> > > > >> > WBR >> >>> >>> > > > >> > Maxim aka solomax >> >>> >>> > > > >> > >> >>> >>> > > > >> >> >>> >>> > > > >> >> >>> >>> > > > >> >> >>> >>> > > > >> -- >> >>> >>> > > > >> Thanks and regards >> >>> >>> > > > >> Madasamy >> >>> >>> > > > >> >> >>> >>> > > > > >> >>> >>> > > > > >> >>> >>> > > > > >> >>> >>> > > > > -- >> >>> >>> > > > > WBR >> >>> >>> > > > > Maxim aka solomax >> >>> >>> > > > > >> >>> >>> > > > >> >>> >>> > > > >> >>> >>> > > > >> >>> >>> > > > -- >> >>> >>> > > > WBR >> >>> >>> > > > Maxim aka solomax >> >>> >>> > > > >> >>> >>> > > >> >>> >>> > >> >>> >>> > >> >>> >>> > >> >>> >>> > -- >> >>> >>> > WBR >> >>> >>> > Maxim aka solomax >> >>> >>> > >> >>> >>> >> >>> >> >> >>> >> >> >>> >> >> >>> >> -- >> >>> >> WBR >> >>> >> Maxim aka solomax >> >>> >> >> >>> > >> >>> > >> >>> > >> >>> > -- >> >>> > WBR >> >>> > Maxim aka solomax >> >>> > >> >>> >> >>> >> >>> >> >>> -- >> >>> WBR >> >>> Maxim aka solomax >> >>> >> >> >> >> >> > >> > > > > -- > WBR > Maxim aka solomax > -- WBR Maxim aka solomax
