Hi Maxim, I do not understand the changes you introduced to AbstractSelect2Choice.java in https://github.com/wicketstuff/core/commit/92851a253253849582a117d66dee5fcdb15c7353:
1. you added a "private List<T> choices“ property, what is the purpose of this? Isn’t the ChoiceProvider supposed to provide the list of choices? 2. in lines 130 and 133 you throw an IllegalStateException if either choices or renderer is null. Besides the fact that I didn’t get the purpose of the „choices“ list yet: this breaks several of our implementations, as we have select2 implementations where it’s not possible to determine the ChoiceProvider upon construction, but e.g. in onInitialize (we have several abstract select2 choice classes, where only the concrete implementation can know which choiceprovider to use …) 3. you can now call the constructor in line 74 (public AbstractSelect2Choice(String id, IModel<M> model)) which generates above mentioned IllegalStateException … 4. methods added starting in line 351: these use the newly introduced List<T> choices, could you explain the idea behind that? Thanks in advance! -Tom > On 30.11.2014, at 16:32, Maxim Solodovnik <solomax...@gmail.com> wrote: > > Merged! > > Seems to work as expected in our application > Thanks for the fix Martin! > > On Wed, Nov 26, 2014 at 10:20 AM, Maxim Solodovnik <solomax...@gmail.com> > wrote: > >> Thanks a lot! >> I'll backport! >> >> On Wed, Nov 26, 2014 at 1:34 AM, Martin Grigorov <mgrigo...@apache.org> >> wrote: >> >>> Fixed with >>> >>> https://github.com/wicketstuff/core/commit/b7e5b68b858336d85958663204166bd0852b43dd >>> Hopefully all other use cases are still covered. >>> >>> I just noticed that there is >>> >>> https://github.com/wicketstuff/core/tree/wicket-6.x/jdk-1.6-parent/select2-parent >>> (i.e. Wicket 6.x version). >>> It would be good if someone backports the improvements from master branch >>> to wicket-6.x: >>> >>> https://github.com/wicketstuff/core/commits/master/jdk-1.7-parent/select2-parent >>> It seems Igor has been active last month at >>> https://github.com/ivaynberg/wicket-select2/ and merged few PRs. I've >>> ported them to WicketStuff 7.x but not to 6.x. >>> >>> Martin Grigorov >>> Wicket Training and Consulting >>> https://twitter.com/mtgrigorov --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
