I use to say "because Windows users decided to suffer themselves (with the decision to use Windows)" :-)
If you find the reason and a solution then we would be happy to apply it (unless it breaks the less-problematic OS-es) Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Fri, Feb 13, 2015 at 10:30 PM, Chris Colman <[email protected] > wrote: > There is a comment about this issue in the parent pom.xml. > > For anyone else who gest this issue you can find the clirr-maven-plugin > in the parent pom.xml and change failOnError to false to allow the build > to complete. > > <configuration> > <comparisonVersion>6.0.0</comparisonVersion> > <failOnError>false</failOnError> > <logResults>true</logResults> > <ignored> > <difference> > <!-- FeedbackCollector used to be final. Now it > is non-final and so all existing methods were made final to keep them > non-overridable. However, clirr does not take into account the class > going from final to non-final and thinks overridable methods were made > final. We ignore this change to silence it. --> > > <className>org${file.separator}apache${file.separator}wicket${file.separ > ator}feedback${file.separator}FeedbackCollector</className> > <method>*</method> > <differenceType>7014</differenceType> > </difference> > </ignored> > </configuration> > > I'm not sure why it's a Windows only problem when the plugin config is > using file.separator and not explicitly '/' > > > -----Original Message----- > > From: Tobias Soloschenko [mailto:[email protected]] > > Sent: Saturday, 14 February 2015 5:06 AM > > To: [email protected] > > Subject: Re: Error building wicket-6.19.0 from src > > > > Hi, > > > > which Java Version are you using currently? There is an issue of the > > clirr plugin not to work with Java 8 at the moment. I filed in a > ticket: > > > > https://issues.apache.org/jira/browse/WICKET-5836 > > > > kind regards > > > > Tobias > > > > Am 13.02.15 um 18:43 schrieb Chris Colman: > > > I'm compiling on Windows 8.1 64bit if that makes any difference. > > > > > > A few years ago there was an issue with clirr due to a forward > > > slash/backslash issue which caused it to compile ok on Linux/Mac but > > > fail on Windows but I'm pretty sure that was resolved a long time > ago. > > > > > > Regards, > > > Chris > > > > > >> -----Original Message----- > > >> From: Martin Grigorov [mailto:[email protected]] > > >> Sent: Thursday, 12 February 2015 11:22 PM > > >> To: [email protected] > > >> Subject: Re: Error building wicket-6.19.0 from src > > >> > > >> Hi, > > >> > > >> According to the SCM history [1] this class hasn't been changed > since > > > Nov > > >> 26 2012. > > >> > > >> > > >> 1. > > >> https://github.com/apache/wicket/commits/wicket-6.x/wicket- > > >> > core/src/main/java/org/apache/wicket/feedback/FeedbackCollector.java > > >> > > >> Martin Grigorov > > >> Wicket Training and Consulting > > >> https://twitter.com/mtgrigorov > > >> > > >> On Thu, Feb 12, 2015 at 12:59 PM, Chris Colman > > >> <[email protected] > > >>> wrote: > > >>> I get the following error when I try to compile the 6.19.0 source > > > code: > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: > Method > > >>> 'public java.util.List collect()' is now final > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method > > >>> 'public java.util.List collect(org.apache.wicket.feed > > >>> back.IFeedbackMessageFilter)' is now final > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method > > >>> 'public org.apache.wicket.feedback.FeedbackCollector > > >>> setIncludeSession(boolean)' is now final > > >>> [ERROR] 7014: org.apache.wicket.feedback.FeedbackCollector: Method > > >>> 'public org.apache.wicket.feedback.FeedbackCollector > > >>> setRecursive(boolean)' is now final > > >>> > > >>> Any idea what could be causing this? > > >>> > > >>> Regards, > > >>> Chris > > >>> > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [email protected] > > > For additional commands, e-mail: [email protected] > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
