https://github.com/l0rdn1kk0n/wicket-bootstrap/pull/575
Created a new PR with a proper title On Sat, Jan 2, 2016 at 1:47 AM, Tobias Soloschenko < tobiassolosche...@googlemail.com> wrote: > Hi, > > yep - good point about squashing. > > kind regards > > Tobias > > > Am 01.01.2016 um 21:34 schrieb Martin Grigorov <mgrigo...@apache.org>: > > > > Hi, > > > > On Fri, Jan 1, 2016 at 8:17 PM, Tobias Soloschenko < > > tobiassolosche...@googlemail.com> wrote: > > > >> Hi, > >> > >> tests only from what is possible - if there is markup which can be > tested. > >> > >> @martin - Are there integration tests @ Wicket bootstrap? > > > > No. > > > > > >> > >> kind regards > >> > >> Tobias > >> > >>>> Am 01.01.2016 um 18:03 schrieb Ernesto Reinaldo Barreiro < > >>> reier...@gmail.com>: > >>> > >>> Are you talking about client side tests? Mind that component is just > 90% > >>> JavaScript and java is just a thin layer on top. > >>> > >>> On Fri, Jan 1, 2016 at 2:54 PM, Tobias Soloschenko < > >>> tobiassolosche...@googlemail.com> wrote: > >>> > >>>> Hi, > >>>> > >>>> thank you for checking it and for your contributions! :-) > >>>> > >>>> I suggest to first create a PR against wicket-bootstrap 6.x. It would > be > > > > It doesn't matter which branch is the target. > > Just please squash the commits at the end. > > > > > >>>> great to create a package for it and write some unit tests. After it > is > >>>> integrated with all changes of comments in the PR it can easily be > >> cherry > >>>> picked for other branches and of course changed / simplified for the > >> newer > >>>> java versions. This way it is integrated within all branches with less > >> work > >>>> to do. > >>>> > >>>> kind regards > >>>> > >>>> Tobias > >>>> > >>>>>> Am 01.01.2016 um 13:24 schrieb Ernesto Reinaldo Barreiro < > >>>>> reier...@gmail.com>: > >>>>> > >>>>> I confirm component works too for wicket 6.x applications: my project > >>>> still > >>>>> uses latest wicket 6 > >>>>> > >>>>> On Fri, Jan 1, 2016 at 11:45 AM, Ernesto Reinaldo Barreiro < > >>>>> reier...@gmail.com> wrote: > >>>>> > >>>>>> Thanks for feedback. I think this component will work as it is also > >> with > >>>>>> 6.x branch... Additionally I also have other bootstrap based > >> components > >>>>>> that I use on my project that I might contribute to > wicket-bootstrap. > >>>> Let > >>>>>> me see If I find the time to integrate them :-) > >>>>>> > >>>>>> On Fri, Jan 1, 2016 at 11:36 AM, Tobias Soloschenko < > >>>>>> tobiassolosche...@googlemail.com> wrote: > >>>>>> > >>>>>>> Hi, > >>>>>>> > >>>>>>> great - and that fast! Looking forward to review the PR. :-) > >>>>>>> > >>>>>>> kind regards > >>>>>>> > >>>>>>> Tobias > >>>>>>> > >>>>>>>>> Am 01.01.2016 um 11:14 schrieb Ernesto Reinaldo Barreiro < > >>>>>>>> reier...@gmail.com>: > >>>>>>>> > >>>>>>>> Hi, > >>>>>>>> > >>>>>>>> I have added all the essential features I need for my project. You > >> can > >>>>>>> see > >>>>>>>> the result in action here > >>>>>>>> > >>>>>>>> http://ns331816.ip-188-165-220.eu/demo/slider > >>>>>>>> > >>>>>>>> I will for sure add more features while integrating it with my > >>>>>>> project... > >>>>>>>> But for now we have a minimal working integration. Please feel > free > >> to > >>>>>>>> comment and suggest :-) > >>>>>>>> > >>>>>>>> Cheers and happy new year to all of you celebrating new year > around > >>>> this > >>>>>>>> date :-) > >>>>>>>> > >>>>>>>> > >>>>>>>> On Wed, Dec 30, 2015 at 12:31 PM, Tobias Soloschenko < > >>>>>>>> tobiassolosche...@googlemail.com> wrote: > >>>>>>>> > >>>>>>>>> Great! Looking forward to see the result! :-) > >>>>>>>>> > >>>>>>>>> Thank you! > >>>>>>>>> > >>>>>>>>> kind regards > >>>>>>>>> > >>>>>>>>> Tobias > >>>>>>>>> > >>>>>>>>>> Am 30.12.2015 um 12:21 schrieb Maxim Solodovnik < > >>>> solomax...@gmail.com > >>>>>>>> : > >>>>>>>>>> > >>>>>>>>>> Thanks Ernesto > >>>>>>>>>> I believe this will be useful component :) > >>>>>>>>>> > >>>>>>>>>> On Wed, Dec 30, 2015 at 5:20 PM, Ernesto Reinaldo Barreiro < > >>>>>>>>>> reier...@gmail.com> wrote: > >>>>>>>>>> > >>>>>>>>>>> https://github.com/l0rdn1kk0n/wicket-bootstrap/pull/574 > >>>>>>>>>>> > >>>>>>>>>>> work in progress :-) > >>>>>>>>>>> > >>>>>>>>>>> On Wed, Dec 30, 2015 at 9:16 AM, Ernesto Reinaldo Barreiro < > >>>>>>>>>>> reier...@gmail.com> wrote: > >>>>>>>>>>> > >>>>>>>>>>>> Thanks to you both for helping keep wicket alive and kicking! > >>>>>>>>>>>> > >>>>>>>>>>>> On Wed, Dec 30, 2015 at 9:13 AM, Martin Grigorov < > >>>>>>> mgrigo...@apache.org > >>>>>>>>>> > >>>>>>>>>>>> wrote: > >>>>>>>>>>>> > >>>>>>>>>>>>> Thank you, Ernesto! > >>>>>>>>>>>>> On Dec 30, 2015 10:12 AM, "Ernesto Reinaldo Barreiro" < > >>>>>>>>>>> reier...@gmail.com > >>>>>>>>>>>>> wrote: > >>>>>>>>>>>>> > >>>>>>>>>>>>>> Thanks for your replay. I will roll out such an > implementation > >>>> and > >>>>>>>>>>>>> create a > >>>>>>>>>>>>>> PR against wicket-bootstrap > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> On Wed, Dec 30, 2015 at 9:09 AM, Tobias Soloschenko < > >>>>>>>>>>>>>> tobiassolosche...@googlemail.com> wrote: > >>>>>>>>>>>>>> > >>>>>>>>>>>>>>> Hi, > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> from what I can see on Wicket bootstrap - there is no > >>>> integration > >>>>>>>>>>> for > >>>>>>>>>>>>>> that: > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> http://wb-mgrigorov.rhcloud.com/components > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> But it should be no problem to implement it. :-) > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> kind regards > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> Tobias > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>> Am 30.12.2015 um 08:21 schrieb Ernesto Reinaldo Barreiro > < > >>>>>>>>>>>>>>>> reier...@gmail.com>: > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> Hi Wicketeers, > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> Does anyone has rolled out a wicket wrapper for > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> http://www.eyecon.ro/bootstrap-slider/ > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> ? > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> -- > >>>>>>>>>>>>>>>> Regards - Ernesto Reinaldo Barreiro > >>>> --------------------------------------------------------------------- > >>>>>>>>>>>>>>> To unsubscribe, e-mail: > users-unsubscr...@wicket.apache.org > >>>>>>>>>>>>>>> For additional commands, e-mail: > >> users-h...@wicket.apache.org > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> -- > >>>>>>>>>>>>>> Regards - Ernesto Reinaldo Barreiro > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>>> -- > >>>>>>>>>>>> Regards - Ernesto Reinaldo Barreiro > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> -- > >>>>>>>>>>> Regards - Ernesto Reinaldo Barreiro > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> -- > >>>>>>>>>> WBR > >>>>>>>>>> Maxim aka solomax > >> --------------------------------------------------------------------- > >>>>>>>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > >>>>>>>>> For additional commands, e-mail: users-h...@wicket.apache.org > >>>>>>>> > >>>>>>>> > >>>>>>>> -- > >>>>>>>> Regards - Ernesto Reinaldo Barreiro > >>>>>>> > >>>>>>> > --------------------------------------------------------------------- > >>>>>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > >>>>>>> For additional commands, e-mail: users-h...@wicket.apache.org > >>>>>> > >>>>>> > >>>>>> -- > >>>>>> Regards - Ernesto Reinaldo Barreiro > >>>>> > >>>>> > >>>>> > >>>>> -- > >>>>> Regards - Ernesto Reinaldo Barreiro > >>>> > >>>> --------------------------------------------------------------------- > >>>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > >>>> For additional commands, e-mail: users-h...@wicket.apache.org > >>> > >>> > >>> -- > >>> Regards - Ernesto Reinaldo Barreiro > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > >> For additional commands, e-mail: users-h...@wicket.apache.org > >> > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > > -- Regards - Ernesto Reinaldo Barreiro
