On Mon, Mar 13, 2017 at 6:11 PM, Francois Meillet < [email protected]> wrote:
> found that org.apache.wicket:wicket-core:jar:8.0.0-M4 use > com.tdunning:json > > <dependency> > <groupId>com.tdunning</groupId> > <artifactId>json</artifactId> > </dependency> > > > de.agilecoders.wicket:wicket-bootstrap-extensions:jar:2.0.0-M2 use > com.google.javascript:closure-compiler:v20130603 > > <dependency> > <groupId>com.google.javascript</groupId> > <artifactId>closure-compiler</artifactId> > <version>v20130603</version> > </dependency> > > which use org.json:json > > <dependency> > <groupId>org.json</groupId> > <artifactId>json</artifactId> > <version>20090211</version> > </dependency> > > > Both json projects have the same package structure and the same class > naming > This is a similar problem like the one at https://issues.apache.org/jira/browse/WICKET-6329 But still this doesn't explain why 8.0.0-SNAPSHOT doesn't have the problem for you. Wicket uses org.github.openjson to generate its JS stuff and it has been fixed just an hour ago. > > > François > > > > > Le 13 mars 2017 à 15:43, Martin Grigorov <[email protected]> a écrit > : > > > > On Mon, Mar 13, 2017 at 3:23 PM, Francois Meillet < > > [email protected] <mailto:[email protected]>> wrote: > > > >> AbstractDefaultAjaxBehavior > >> > >> protected final CharSequence renderAjaxAttributes(final Component > >> component, AjaxRequestAttributes attributes) { > >> > >> .../... > >> > >> > >> List<CharSequence> dynamicExtraParameters = > >> attributes.getDynamicExtraParameters(); > >> if (dynamicExtraParameters != null) > >> { > >> for (CharSequence dynamicExtraParameter : > >> dynamicExtraParameters) > >> { > >> String func = > >> String.format(DYNAMIC_PARAMETER_FUNCTION_TEMPLATE, > dynamicExtraParameter); > >> > >> ---> 8.0.0-SNAPSHOT func = > >> function(attrs){return Wicket.BrowserInfo.collect()} > >> > >> ---> 8.0.0-M4 > >> func = function(attrs){return Wicket.BrowserInfo.collect()} > >> > >> > >> JSONFunction function = new > >> JSONFunction(func); > >> attributesJson.append( > >> AjaxAttributeName.DYNAMIC_PARAMETER_FUNCTION.jsonName(), function); > >> > >> ---> 8.0.0-SNAPSHOT > >> attributesJson.toString() = {"u":"./.?2-1.0-","dep":[ > function(attrs){return > >> Wicket.BrowserInfo.collect()}]} > >> > >> ---> 8.0.0-M4 > >> attributesJson.toString() = {"u":"./.?2-1.0-","dep":[" > function(attrs){return > >> Wicket.BrowserInfo.collect()}"]} > >> > > > > I don't see why this works in -SNAPSHOT ... > > https://github.com/openjson/openjson/blob/master/src/main/ > java/com/github/openjson/JSONObject.java#L327 < > https://github.com/openjson/openjson/blob/master/src/main/ > java/com/github/openjson/JSONObject.java#L327> > > doesn't have support for lists/collections yet > > > > > >> } > >> } > >> > >> François > >> > >> > >> > >>> Le 13 mars 2017 à 11:57, Martin Grigorov <[email protected]> a > écrit > >> : > >>> > >>> 8.0.0-SNAPSHOT uses https://github.com/openjson/openjson > >>> But AFAIK the problem is not fixed there. If you have time to debug why > >> it > >>> works it would be helpful! > >>> Mikhail is going to implement the missing #put(String, Collection|Map) > >>> methods and make a release. Then we will update all branches! > >>> > >>> Martin Grigorov > >>> Wicket Training and Consulting > >>> https://twitter.com/mtgrigorov > >>> > >>> On Mon, Mar 13, 2017 at 11:44 AM, Francois Meillet < > >>> [email protected]> wrote: > >>> > >>>> Hi Martin, > >>>> > >>>> I do not get any error with the 8.0.0-SNAPSHOT > >>>> > >>>> François > >>>> > >>>> > >>>> > >>>>> Le 13 mars 2017 à 10:14, Martin Grigorov <[email protected]> a > >> écrit > >>>> : > >>>>> > >>>>> Hi Francois, > >>>>> > >>>>> It is strange that it fails when built on Mac only. > >>>>> But the issue looks the same as the one reported by Sebastien. > >>>>> > >>>>> Martin Grigorov > >>>>> Wicket Training and Consulting > >>>>> https://twitter.com/mtgrigorov > >>>>> > >>>>> On Mon, Mar 13, 2017 at 8:09 AM, Francois Meillet < > >>>>> [email protected]> wrote: > >>>>> > >>>>>> I forgot to say : Apache Wicket 8.0.0-M4 > >>>>>> > >>>>>> François > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>> > >>>> > >>>> --------------------------------------------------------------------- > >>>> To unsubscribe, e-mail: [email protected] > >>>> For additional commands, e-mail: [email protected] > >>>> > >>>> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] <mailto: > [email protected]> > >> For additional commands, e-mail: [email protected] <mailto: > [email protected]> >
