Hi,

On Fri, May 25, 2018 at 11:38 AM, Tobias Gierke <
tobias.gie...@voipfuture.com> wrote:

> Hi,
>
>> Hi,
>>
>> this should be caused by WICKET-6498. This issue has changed the behavior
>> for HeaderResponseDecorator. You can find how to adapt your code in the
>> migration guide or in the release note of Milestone 9:
>>
>
> Btw, could you maybe enhance the migration guide to include a warning
> about JS event names like "onclick","onblur" etc. no longer working ?
>
> I know that Wicket 7.x used to printed lots of warnings about this but
> somehow we (and probably others as well) were too lazy to fix them when
> upgrading to 7.x and now the warnings are gone but AJAX behaviors using the
> old event names stopped working completely.
>

Those warnings were added at 6.x and since 7.0.0.
For 8.0.0-Mx (the milestones) they were errors, i.e. throwing exceptions,
and we reomved them just before 8.0.0.
Maybe you can use -M9 temporarily just to fix them in your code base ?


>
> Thanks,
> Tobias
>
>>
>> https://wicket.apache.org/news/2018/02/17/wicket-8.0.0-M9-released.html
>>
>>
>>
>>
>> On 23/05/2018 17:55, Tobias Gierke wrote:
>>
>>> Hi,
>>>
>>> I'm in the process of migrating our application from Wicket 7.10 to
>>> Wicket 8 and encountered some weirdness with regards to header
>>> contributions.
>>>
>>> Our application has a top-level WebPage that defines a
>>> HeaderResponseContainerat the very end of the page markup and all other
>>> application pages inherit from it. We have a few header items that need to
>>> be rendered in their own section at the bottom of the page so I basically
>>> took the approach outlined in http://tomaszdziurko.com/2017/
>>> 02/forcing-wicket-place-javascript-files-bottom/ and adopted it to our
>>> needs.
>>>
>>> Our Application#init() method does this:
>>>
>>> -----------------------------------final IHeaderResponseDecorator
>>> headerResponseDecorator =new IHeaderResponseDecorator()
>>>    {
>>>       @Override public IHeaderResponse decorate(IHeaderResponse response)
>>>       {
>>>          return new FilteringHeaderResponse(response);
>>>       }
>>>    };
>>>    setHeaderResponseDecorator(headerResponseDecorator);
>>> -----------------------------------
>>>
>>> And from inside Behavior#renderHead() we're doing
>>>
>>> -----------------------------------final OnDomReadyHeaderItem toWrap =
>>> OnDomReadyHeaderItem.forScript(script);
>>> response.render(new FilteredHeaderItem(toWrap, "our-bucket" );
>>> -----------------------------------
>>>
>>> This was working fine in Wicket 7.10 but with Wicket 8 the Wicket
>>> defeault Javascript files (wicket-event-jquery,wicket-ajax-jquery etc.)
>>> are no longer being included in the page so AJAX buttons etc. fail with
>>> "TypeError: Wicket.Event is undefined" etc.
>>>
>>> Wrapping the FilteringHeaderResponse inside a ResourceAggregator like||
>>> shown in the migration guide had no effect.
>>>
>>>
>>> Thanks,
>>> Tobias
>>>
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
>> For additional commands, e-mail: users-h...@wicket.apache.org
>>
>>
> --
> Tobias Gierke
> Software Developer
>
> Voipfuture GmbH   Wendenstr. 4   20097 Hamburg   Germany
> Phone +49 40 688 9001 64   Fax +49 40 688 9001 99   www.voipfuture.com
> Managing Directors   Jan Bastian   Eyal Ullert
> Commercial Court AG Hamburg   HRB 109896   VAT ID DE263738086
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>

Reply via email to