Hi, I've added a note at the beginning of the migration guide listing important changes that should be checked during migration even if you don't have compilation problems. Feel free to improve/enrich it.
On Fri, May 25, 2018 at 11:42 AM, Sven Meier <s...@meiers.net> wrote: > Hi, > > it would be great if you could provide a quickstart showing the problem. > > Thanks > Sven > > > > Am 25.05.2018 um 10:34 schrieb Tobias Gierke: > >> Hi, >> >>> Hi Thomas, >>> >>> that should work. >>> >>> Could you please compare your setup with the one in >>> https://github.com/apache/wicket/tree/master/wicket-examples >>> /src/main/java/org/apache/wicket/examples/resourcedecoration >>> >> My code is identical except I'm using FilteringHeaderResponse with a >> custom "bucket" name instead of JavaScriptFilteredIntoFooterHe >> aderResponse. >> >> Anyway, for the time being I solved my issue by fixing my HeaderItem >> dependencies and just deleting my custom header decoration stuff (as it >> turned out I was basically abusing this feature to work around my broken >> HeaderItem dependencies :-) >> >> I still feel that the WICKET-6498 change somehow interacts with >> FilteringHeaderResponse in a not-too-obvious way (our code used to work in >> 7.10 but fails in 8.0.0). >> >> Cheers, >> Tobi >> >>> >>> Thanks >>> Sven >>> >>> Am 24. Mai 2018 08:43:47 MESZ schrieb Tobias Gierke < >>> tobias.gie...@code-sourcery.de>: >>> >>>> Hi, >>>> >>>>> Hi, >>>>> >>>>> this should be caused by WICKET-6498. This issue has changed the >>>>> behavior for HeaderResponseDecorator. You can find how to adapt your >>>>> code in the migration guide or in the release note of Milestone 9: >>>>> >>>>> >>>>> https://wicket.apache.org/news/2018/02/17/wicket-8.0.0-M9- >>>> released.html >>>> >>>> Thanks for the quick response! I already tried this and it didn't have >>>> any effect :/ >>>> >>>> My Application#init() method is doing: >>>> >>>> setHeaderResponseDecorator( response ->new ResourceAggregator(new >>>> FilteringHeaderResponse(response) ) ); >>>> >>>> >>>> >>>> Cheers, >>>> Tobias >>>> >>> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > >
