Hi Denis, > On 18 Jan 2017, at 15:46, Denis GERMAIN <dt.germ...@gmail.com> wrote: > > Hi list, > > Vincent Massol has asked for code review after official docker image > annoncement and though I am no Docker expert, I have found a few leads to > reduce image size and might have some suggestions to improve it. > > With 3 little changes I have gained about 500 MB, but I still have to make > sure everything still works. > - 200 of those MB where gained by a commonly used trick : adding > "--no-install-recommends" option to apt-get. > Some packages that are commonly installed with libreoffice might have been > skipped and I still have to determine if it's OK or not. > > - The other 300 MB are safe. Most of it comes from "RUN chown -R > tomcat8:tomcat8 /var/lib/tomcat8" being moved inside the same layer as the > curl xwiki.war && unzip.
This is great! Thanks so much for reviewing it and proposing ideas :) For my knowledge, could you explain quickly how this wins 300MB (it seems magical :))? Also, the image take “only” 900MB (see https://hub.docker.com/r/xwiki/xwiki-mysql-tomcat/tags/) so I don’t understand why it takes 1.6GB for you. Thanks a lot -Vincent > > docker images > REPOSITORY TAG IMAGE > ID CREATED SIZE > xwiki-mysql-tomcat after > b05844c94dd0 7 seconds ago 1.157 GB > xwiki-mysql-tomcat before > 174d549368d5 2 hours ago 1.689 GB > > As soon as I have checked this works, I'll do a pull request. > In the meantime, code is online on > https://github.com/zwindler/docker-xwiki-1/tree/clear_apt > > Regards > Denis GERMAIN
