Hi Damien, I think that #oldBack has no functional value and that your change has a very low risk of breaking things. As Klaus has already pointed out the main function of back, adjusting the position of the stream, does not change.
I think just fixing it would be fine, and I agree it should be fixed. Ron > -----Original Message----- > From: Damien Cassou [mailto:[EMAIL PROTECTED] > Sent: Wednesday, August 01, 2007 11:35 AM > To: [EMAIL PROTECTED]; Discussion about development of Squeak 3.10 > Subject: Re: [V3dot10] Re: 0006583: PositionableStream>>back behavior is > totallywrong > > 2007/8/1, Ron Teitelbaum <[EMAIL PROTECTED]>: > > Klaus, > > > > I was just reading Damien's new code and even though the current > > implementation does position correctly it returns the wrong value. > Damien's > > code returns the proper back value and replaces #next with #peek, to > leave > > the position in the right place. > > > > It's a good change. Not sure I support leaving #oldBack for long > though. > > There doesn't appear to be much use of getting a returned result 2 > positions > > back from a call to oldBack. > > I'm not sure keeping #oldBack is something we want. But, keeping it > may be better accepted by the community. I don't know. What do you > think? > > -- > Damien Cassou _______________________________________________ V3dot10 mailing list [email protected] http://lists.squeakfoundation.org/mailman/listinfo/v3dot10
