max = mid; is correct. The interval is up to but not including max. I've put in a comment to that effect. The code style is fixed.
On Tue, Sep 30, 2008 at 11:50 AM, <[EMAIL PROTECTED]>wrote: > There's a bit of odd code style and a possible +/-1. Otherwise lgtm. > > > http://codereview.chromium.org/6006/diff/1/2 > File src/array.js (right): > > http://codereview.chromium.org/6006/diff/1/2#newcode673 > Line 673: for(var i = from + 1; i < to; i++) { > There should be a space between 'for' and '('. > > http://codereview.chromium.org/6006/diff/1/2#newcode689 > Line 689: max = mid; > I'm not 100% sure but I think this should be max = mid - 1. > > > http://codereview.chromium.org/6006 > -- -- Ole I Hougaard Google Aarhus, Denmark +45 8745 9215 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
