There's a bit of odd code style and a possible +/-1. Otherwise lgtm.
http://codereview.chromium.org/6006/diff/1/2 File src/array.js (right): http://codereview.chromium.org/6006/diff/1/2#newcode673 Line 673: for(var i = from + 1; i < to; i++) { There should be a space between 'for' and '('. http://codereview.chromium.org/6006/diff/1/2#newcode689 Line 689: max = mid; I'm not 100% sure but I think this should be max = mid - 1. http://codereview.chromium.org/6006 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
