Author: [EMAIL PROTECTED]
Date: Tue Oct 21 08:24:58 2008
New Revision: 538
Modified:
branches/bleeding_edge/SConstruct
branches/bleeding_edge/src/api.cc
branches/bleeding_edge/tools/visual_studio/js2c.cmd
Log:
Minor fixes
- support changes to js2c in Visual Studio build
- handle empty handles in Utf8Value
- add /nologo to sample link in SCons build
TBR=plesner
Review URL: http://codereview.chromium.org/7816
Modified: branches/bleeding_edge/SConstruct
==============================================================================
--- branches/bleeding_edge/SConstruct (original)
+++ branches/bleeding_edge/SConstruct Tue Oct 21 08:24:58 2008
@@ -197,6 +197,7 @@
'msvc': {
'all': {
'CCFLAGS': ['/nologo'],
+ 'LINKFLAGS': ['/nologo'],
},
'library:shared': {
'CPPDEFINES': ['USING_V8_SHARED']
Modified: branches/bleeding_edge/src/api.cc
==============================================================================
--- branches/bleeding_edge/src/api.cc (original)
+++ branches/bleeding_edge/src/api.cc Tue Oct 21 08:24:58 2008
@@ -2623,6 +2623,11 @@
String::Utf8Value::Utf8Value(v8::Handle<v8::Value> obj) {
EnsureInitialized("v8::String::Utf8Value::Utf8Value()");
+ if (obj.IsEmpty()) {
+ str_ = NULL;
+ length_ = 0;
+ return;
+ }
HandleScope scope;
TryCatch try_catch;
Handle<String> str = obj->ToString();
Modified: branches/bleeding_edge/tools/visual_studio/js2c.cmd
==============================================================================
--- branches/bleeding_edge/tools/visual_studio/js2c.cmd (original)
+++ branches/bleeding_edge/tools/visual_studio/js2c.cmd Tue Oct 21 08:24:58
2008
@@ -3,4 +3,4 @@
set TARGET_DIR=%2
set PYTHON="..\..\..\third_party\python_24\python.exe"
if not exist %PYTHON% set PYTHON=python.exe
-%PYTHON% ..\js2c.py %TARGET_DIR%\natives.cc %TARGET_DIR%\natives-empty.cc
%SOURCE_DIR%\macros.py %SOURCE_DIR%\runtime.js %SOURCE_DIR%\v8natives.js
%SOURCE_DIR%\array.js %SOURCE_DIR%\string.js %SOURCE_DIR%\uri.js
%SOURCE_DIR%\math.js %SOURCE_DIR%\messages.js %SOURCE_DIR%\apinatives.js
%SOURCE_DIR%\debug-delay.js %SOURCE_DIR%\mirror-delay.js
%SOURCE_DIR%\date-delay.js %SOURCE_DIR%\regexp-delay.js
+%PYTHON% ..\js2c.py %TARGET_DIR%\natives.cc %TARGET_DIR%\natives-empty.cc
CORE %SOURCE_DIR%\macros.py %SOURCE_DIR%\runtime.js %SOURCE_DIR%\v8natives.js
%SOURCE_DIR%\array.js %SOURCE_DIR%\string.js %SOURCE_DIR%\uri.js
%SOURCE_DIR%\math.js %SOURCE_DIR%\messages.js %SOURCE_DIR%\apinatives.js
%SOURCE_DIR%\debug-delay.js %SOURCE_DIR%\mirror-delay.js
%SOURCE_DIR%\date-delay.js %SOURCE_DIR%\regexp-delay.js
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
