Reviewers: Christian Plesner Hansen, Description: Minor fixes
- support changes to js2c in Visual Studio build - handle empty handles in Utf8Value - add /nologo to sample link in SCons build TBR=plesner Please review this at http://codereview.chromium.org/7816 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M SConstruct M src/api.cc M tools/visual_studio/js2c.cmd Index: tools/visual_studio/js2c.cmd =================================================================== --- tools/visual_studio/js2c.cmd (revision 537) +++ tools/visual_studio/js2c.cmd (working copy) @@ -3,4 +3,4 @@ set TARGET_DIR=%2 set PYTHON="..\..\..\third_party\python_24\python.exe" if not exist %PYTHON% set PYTHON=python.exe -%PYTHON% ..\js2c.py %TARGET_DIR%\natives.cc %TARGET_DIR%\natives-empty.cc %SOURCE_DIR%\macros.py %SOURCE_DIR%\runtime.js %SOURCE_DIR%\v8natives.js %SOURCE_DIR%\array.js %SOURCE_DIR%\string.js %SOURCE_DIR%\uri.js %SOURCE_DIR%\math.js %SOURCE_DIR%\messages.js %SOURCE_DIR%\apinatives.js %SOURCE_DIR%\debug-delay.js %SOURCE_DIR%\mirror-delay.js %SOURCE_DIR%\date-delay.js %SOURCE_DIR%\regexp-delay.js +%PYTHON% ..\js2c.py %TARGET_DIR%\natives.cc %TARGET_DIR%\natives-empty.cc CORE %SOURCE_DIR%\macros.py %SOURCE_DIR%\runtime.js %SOURCE_DIR%\v8natives.js %SOURCE_DIR%\array.js %SOURCE_DIR%\string.js %SOURCE_DIR%\uri.js %SOURCE_DIR%\math.js %SOURCE_DIR%\messages.js %SOURCE_DIR%\apinatives.js %SOURCE_DIR%\debug-delay.js %SOURCE_DIR%\mirror-delay.js %SOURCE_DIR%\date-delay.js %SOURCE_DIR%\regexp-delay.js Index: src/api.cc =================================================================== --- src/api.cc (revision 537) +++ src/api.cc (working copy) @@ -2623,6 +2623,11 @@ String::Utf8Value::Utf8Value(v8::Handle<v8::Value> obj) { EnsureInitialized("v8::String::Utf8Value::Utf8Value()"); + if (obj.IsEmpty()) { + str_ = NULL; + length_ = 0; + return; + } HandleScope scope; TryCatch try_catch; Handle<String> str = obj->ToString(); Index: SConstruct =================================================================== --- SConstruct (revision 537) +++ SConstruct (working copy) @@ -197,6 +197,7 @@ 'msvc': { 'all': { 'CCFLAGS': ['/nologo'], + 'LINKFLAGS': ['/nologo'], }, 'library:shared': { 'CPPDEFINES': ['USING_V8_SHARED'] --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
