See comment in line. Generally this LGTM, but I really think we should add a NO_TYPE or INVALID_TYPE to the InstanceType enum.
http://codereview.chromium.org/7826/diff/1/2 File src/factory.cc (right): http://codereview.chromium.org/7826/diff/1/2#newcode686 Line 686: InstanceType type = JS_OBJECT_TYPE; // initialize to a valid value I would prefer to see a NO_TYPE in the InstanceType enum to be able to clearly indicate that this variable initialization is expected to be overridden. I understand that there currently is no such invalid InstanceType. http://codereview.chromium.org/7826 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
