Reviewers: Christian Plesner Hansen, Description: Added handling of empty handles to String::AsciiValue and String::Value.
Please review this at http://codereview.chromium.org/7832 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/api.cc Index: src/api.cc =================================================================== --- src/api.cc (revision 538) +++ src/api.cc (working copy) @@ -2649,6 +2649,11 @@ String::AsciiValue::AsciiValue(v8::Handle<v8::Value> obj) { EnsureInitialized("v8::String::AsciiValue::AsciiValue()"); + if (obj.IsEmpty()) { + str_ = NULL; + length_ = 0; + return; + } HandleScope scope; TryCatch try_catch; Handle<String> str = obj->ToString(); @@ -2670,6 +2675,11 @@ String::Value::Value(v8::Handle<v8::Value> obj) { EnsureInitialized("v8::String::Value::Value()"); + if (obj.IsEmpty()) { + str_ = NULL; + length_ = 0; + return; + } HandleScope scope; TryCatch try_catch; Handle<String> str = obj->ToString(); --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
