LGTM. Please explain catcher_ though...
http://codereview.chromium.org/8101/diff/1/3 File src/top.cc (right): http://codereview.chromium.org/8101/diff/1/3#newcode610 Line 610: // Set the exception beeing re-thrown. beeing sb. being http://codereview.chromium.org/8101/diff/1/4 File src/top.h (right): http://codereview.chromium.org/8101/diff/1/4#newcode56 Line 56: v8::TryCatch* catcher_; Maybe you should explain what the difference between try_catch_handler_ and catcher_ is? http://codereview.chromium.org/8101/diff/1/4#newcode150 Line 150: (Top::thread_local_.try_catch_handler_ == Top::thread_local_.catcher_); Why do you use Top:: here? You're inside Top, right? http://codereview.chromium.org/8101/diff/1/2 File test/mjsunit/api-call-after-overridden-exception.js (right): http://codereview.chromium.org/8101/diff/1/2#newcode31 Line 31: { Move { to previous line. http://codereview.chromium.org/8101 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
