Lgtm, with comments.
http://codereview.chromium.org/8101/diff/1/4 File src/top.h (right): http://codereview.chromium.org/8101/diff/1/4#newcode56 Line 56: v8::TryCatch* catcher_; What about a more descriptive name for this one? active_external_handler_ maybe? http://codereview.chromium.org/8101/diff/1/4#newcode150 Line 150: (Top::thread_local_.try_catch_handler_ == Top::thread_local_.catcher_); If the catcher is set won't it always be the top exception handler? http://codereview.chromium.org/8101 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
