LGTM.
On Fri, Oct 24, 2008 at 11:28 AM, <[EMAIL PROTECTED]> wrote:
>
> Author: [EMAIL PROTECTED]
> Date: Fri Oct 24 02:27:53 2008
> New Revision: 581
>
> Added:
> changes/[EMAIL PROTECTED]/issue122/
> changes/[EMAIL PROTECTED]/issue122/bleeding_edge/
> - copied from r579, /branches/bleeding_edge/
> Modified:
> changes/[EMAIL PROTECTED]/issue122/bleeding_edge/src/top.h
> changes/[EMAIL PROTECTED]/issue122/bleeding_edge/test/cctest/test-api.cc
>
> Log:
> Changed the workarround for a GCC compiler bug to be only active for the GCC
> version range for which the bug is known to exist.
>
> Added include to compile with GCC 4.3.1.
>
> BUG=122
>
>
> Modified: changes/[EMAIL PROTECTED]/issue122/bleeding_edge/src/top.h
> ==============================================================================
> --- /branches/bleeding_edge/src/top.h (original)
> +++ changes/[EMAIL PROTECTED]/issue122/bleeding_edge/src/top.h Fri Oct 24
> 02:27:53 2008
> @@ -300,14 +300,14 @@
> };
>
>
> -// TODO(122): If the GCC version is 4.2.0 or higher an additional field is
> added
> -// to this class as a workarround for a bug in the generated code found
> with
> -// GCC 4.2.3.
> +// If the GCC version is 4.1.x or 4.2.x an additional field is added to the
> +// class as a workarround for a bug in the generated code found with these
> +// versions of GCC. See V8 issue 122 for details.
> class SaveContext BASE_EMBEDDED {
> public:
> SaveContext() :
> context_(Top::context()),
> -#if __GNUC_VERSION__ >= 40200
> +#if __GNUC_VERSION__ >= 40100 && __GNUC_VERSION__ < 40300
> dummy_(Top::context()),
> #endif
> prev_(Top::save_context()) {
> @@ -324,7 +324,7 @@
>
> private:
> Handle<Context> context_;
> -#if __GNUC_VERSION__ >= 40200
> +#if __GNUC_VERSION__ >= 40100 && __GNUC_VERSION__ < 40300
> Handle<Context> dummy_;
> #endif
> SaveContext* prev_;
>
> Modified:
> changes/[EMAIL PROTECTED]/issue122/bleeding_edge/test/cctest/test-api.cc
> ==============================================================================
> --- /branches/bleeding_edge/test/cctest/test-api.cc (original)
> +++
> changes/[EMAIL PROTECTED]/issue122/bleeding_edge/test/cctest/test-api.cc
> Fri Oct 24 02:27:53 2008
> @@ -28,6 +28,8 @@
> #include <map>
> #include <string>
>
> +#include <stdlib.h>
> +
> #include "v8.h"
>
> #include "api.h"
>
> >
>
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
