LGTM. Two comments:
http://codereview.chromium.org/8909/diff/1/2 File src/api.cc (right): http://codereview.chromium.org/8909/diff/1/2#newcode2890 Line 2890: if (!i::V8::HasBeenSetup()) return; Does the command sender expect an answer? If so, this seems a bit scary. http://codereview.chromium.org/8909/diff/1/3 File test/cctest/test-debug.cc (right): http://codereview.chromium.org/8909/diff/1/3#newcode3148 Line 3148: static void DummyMessageHandler(const uint16_t* message, int length, void *data) { Does this lint? http://codereview.chromium.org/8909 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
