http://codereview.chromium.org/8909/diff/1/2
File src/api.cc (right):

http://codereview.chromium.org/8909/diff/1/2#newcode2890
Line 2890: if (!i::V8::HasBeenSetup()) return;
On 2008/10/30 10:09:34, Kasper Lund wrote:
> Does the command sender expect an answer? If so, this seems a bit
scary.

All command responses are send through a callback the the function
registered with SetMessageHandler which ensures initialization.

http://codereview.chromium.org/8909/diff/1/3
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/8909/diff/1/3#newcode3148
Line 3148: static void DummyMessageHandler(const uint16_t* message, int
length, void *data) {
On 2008/10/30 10:09:34, Kasper Lund wrote:
> Does this lint?

Sorry, broke the line.

http://codereview.chromium.org/8909

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to