As discussed I think we need to tune this a bit more.
http://codereview.chromium.org/9110/diff/1/3 File regexp2000/src/jsregexp.cc (right): http://codereview.chromium.org/9110/diff/1/3#newcode213 Line 213: if ((regexp_features & ESCAPED_CHARACTERS) != 0) { Since we only really need to know if there were escaped characters this seems like overkill. Consider simplifying this to just do what we need now. http://codereview.chromium.org/9110/diff/1/5 File regexp2000/src/parser.cc (right): http://codereview.chromium.org/9110/diff/1/5#newcode3308 Line 3308: fflush(stdout); Ahem. http://codereview.chromium.org/9110/diff/1/5#newcode3357 Line 3357: // RegExpAtom's containing more than one character. Greengrocers' apostrophe. http://codereview.chromium.org/9110/diff/1/5#newcode3363 Line 3363: uc16 single_char; As discussed, regexps that are just atoms are a common case that we want to be really fast. I think we can do something more efficient than this. http://codereview.chromium.org/9110/diff/1/6 File regexp2000/src/parser.h (right): http://codereview.chromium.org/9110/diff/1/6#newcode151 Line 151: enum RegExpFeatures { Again, I wouldn't do this unless we know we'll need it. Also, consider using a bit field struct rather than manually encoding the bits. http://codereview.chromium.org/9110 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
