Lgtm, except for a bit of indentation confusion in the parser.
http://codereview.chromium.org/9110/diff/204/208 File regexp2000/src/parser.cc (right): http://codereview.chromium.org/9110/diff/204/208#newcode3522 Line 3522: case kEndMarker: Case clauses should be indented. http://codereview.chromium.org/9110/diff/204/208#newcode3571 Line 3571: switch (next()) { 4-character indentation? http://codereview.chromium.org/9110/diff/204/208#newcode3572 Line 3572: case kEndMarker: Should be indented. http://codereview.chromium.org/9110/diff/204/208#newcode3691 Line 3691: case '*': 1-character indentation?!? http://codereview.chromium.org/9110 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
