LGTM. I haven't tried to understand the automatically generated code.
http://codereview.chromium.org/10975/diff/1/4 File src/unicode.h (right): http://codereview.chromium.org/10975/diff/1/4#newcode253 Line 253: static int Convert(uchar c, I'm guessing that FoldCase should correspond to the Canonicalize function of ECMAScript. Is this correct? http://codereview.chromium.org/10975/diff/1/4#newcode259 Line 259: static int Convert(uchar c, And UnfoldCase is the inverse of FoldCase, which can return more than one character, since FoldCase isn't injective. http://codereview.chromium.org/10975/diff/1/5 File test/cctest/test-regexp.cc (right): http://codereview.chromium.org/10975/diff/1/5#newcode735 Line 735: CHECK_EQ(0x212A, unfolded[2]); Is UnfoldCase supposed to be the inverse of the Canonicalize function in ECMAScript? If it is, then the Kelvin sign should not be included. You cannot Canonicalize yourself into ASCII from something outside of ASCII (Canonicalize step 5). http://codereview.chromium.org/10975/diff/1/5#newcode738 Line 738: // Long s do. http://codereview.chromium.org/10975 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
