http://codereview.chromium.org/10975/diff/1/4 File src/unicode.h (right):
http://codereview.chromium.org/10975/diff/1/4#newcode253 Line 253: static int Convert(uchar c, No, this is case folding exactly as it is specified in the unicode spec. We will implement canonicalize on top of it. http://codereview.chromium.org/10975/diff/1/4#newcode259 Line 259: static int Convert(uchar c, It's not a true inverse, it's gives the equivalence classes defined by the fold mapping. Given a character x it yields the set of characters that fold to the same as x. A true inverse would map 'A' to {} since nothing folds to 'A'. http://codereview.chromium.org/10975/diff/1/5 File test/cctest/test-regexp.cc (right): http://codereview.chromium.org/10975/diff/1/5#newcode735 Line 735: CHECK_EQ(0x212A, unfolded[2]); As mentioned, FoldCase is not meant to be Canonicalize. I expect to implement the special case for ASCII in v8 itself. http://codereview.chromium.org/10975 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
