Lgtm
http://codereview.chromium.org/11203/diff/1/2 File regexp2000/src/ast.cc (right): http://codereview.chromium.org/11203/diff/1/2#newcode257 Line 257: static void AddChar(StringStream* stream, uc16 character) { You could just use StringStream::Add("%k", ...). http://codereview.chromium.org/11203/diff/1/2#newcode320 Line 320: AddChar(stream(), chardata[i]); Ditto http://codereview.chromium.org/11203/diff/1/3 File regexp2000/src/ast.h (right): http://codereview.chromium.org/11203/diff/1/3#newcode1206 Line 1206: virtual bool Is##Name(); I'm right on the edge of thinking that this is overkill since we don't use most of these functions. http://codereview.chromium.org/11203/diff/1/6 File regexp2000/src/parser.cc (right): http://codereview.chromium.org/11203/diff/1/6#newcode477 Line 477: if (atom->IsLookahead() || atom->IsAssertion()) { I wonder if this is worthwhile? http://codereview.chromium.org/11203 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
