http://codereview.chromium.org/11203/diff/1/2 File regexp2000/src/ast.cc (right):
http://codereview.chromium.org/11203/diff/1/2#newcode257 Line 257: static void AddChar(StringStream* stream, uc16 character) { "%k" uses the format "\\x%X" for anything outside of 32..255. For this, I prefer a format that has a fixed width, so it doesn't run into nearby letters (i.e., something that can be parsed uniquely again). I also don't want the range 128..255 to be treated as literals, since the interpretation might depend on the code-page. However, it would probably be better to add a new formatting code to StringStream. http://codereview.chromium.org/11203/diff/1/6 File regexp2000/src/parser.cc (right): http://codereview.chromium.org/11203/diff/1/6#newcode477 Line 477: if (atom->IsLookahead() || atom->IsAssertion()) { It probably isn't. It's optimizing the case where the user has written a stupid RegExp to begin with. It might be worthwhile if the following translations can ignore the pathological cases. http://codereview.chromium.org/11203 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
