Tiny comments, otherwise LGTM. -Ivan
http://codereview.chromium.org/11277/diff/1/5 File src/ic-arm.cc (right): http://codereview.chromium.org/11277/diff/1/5#newcode472 Line 472: __ stm(db_w, sp, r1.bit() | r3.bit()); Why are you using r1 and r3 here and not r0 and r1? Are r0 and r2 registers already used for something? If so please document then in the -- State-- above. http://codereview.chromium.org/11277/diff/1/5#newcode636 Line 636: __ ldr(r1, MemOperand(sp)); Can you use a different register as temporary register in the code above so that you do not have to reload they key from memory again here? http://codereview.chromium.org/11277 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
