Author: [EMAIL PROTECTED]
Date: Thu Nov 20 10:12:48 2008
New Revision: 810
Modified:
branches/bleeding_edge/src/assembler-arm.cc
Log:
Turn ASSERT(!rn.is(ip)) into CHECK so the error can be caught in release
mode.
It addresses the problem of 'cmp' instruction that has the side-effect that
ip register
shouldn't be used as rn.
Review URL: http://codereview.chromium.org/11323
Modified: branches/bleeding_edge/src/assembler-arm.cc
==============================================================================
--- branches/bleeding_edge/src/assembler-arm.cc (original)
+++ branches/bleeding_edge/src/assembler-arm.cc Thu Nov 20 10:12:48 2008
@@ -554,7 +554,7 @@
// However, if the original instruction is a 'mov rd, x' (not
setting the
// condition code), then replace it with a 'ldr rd, [pc]'
RecordRelocInfo(x.rmode_, x.imm32_);
- ASSERT(!rn.is(ip)); // rn should never be ip, or will be trashed
+ CHECK(!rn.is(ip)); // rn should never be ip, or will be trashed
Condition cond = static_cast<Condition>(instr & CondMask);
if ((instr & ~CondMask) == 13*B21) { // mov, S not set
ldr(rd, MemOperand(pc, 0), cond);
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
