Reviewers: Feng Qian,

Description:
Remove OS::WcsCpy from platform.h. This function is unused
and is giving us headaches on platforms not supporting wchar_t.


Please review this at http://codereview.chromium.org/11546

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
   M     src/platform-linux.cc
   M     src/platform-macos.cc
   M     src/platform-win32.cc
   M     src/platform.h


Index: src/platform-win32.cc
===================================================================
--- src/platform-win32.cc       (revision 810)
+++ src/platform-win32.cc       (working copy)
@@ -685,13 +685,6 @@
  }


-void OS::WcsCpy(Vector<wchar_t> dest, const wchar_t* src) {
-  int result = wcscpy_s(dest.start(), dest.length(), src);
-  USE(result);
-  ASSERT(result == 0);
-}
-
-
  char *OS::StrDup(const char* str) {
    return _strdup(str);
  }
Index: src/platform-linux.cc
===================================================================
--- src/platform-linux.cc       (revision 810)
+++ src/platform-linux.cc       (working copy)
@@ -185,11 +185,6 @@
  }


-void OS::WcsCpy(Vector<wchar_t> dest, const wchar_t* src) {
-  wcscpy(dest.start(), src);
-}
-
-
  char *OS::StrDup(const char* str) {
    return strdup(str);
  }
Index: src/platform-macos.cc
===================================================================
--- src/platform-macos.cc       (revision 810)
+++ src/platform-macos.cc       (working copy)
@@ -190,11 +190,6 @@
  }


-void OS::WcsCpy(Vector<wchar_t> dest, const wchar_t* src) {
-  wcscpy(dest.start(), src);
-}
-
-
  char *OS::StrDup(const char* str) {
    return strdup(str);
  }
Index: src/platform.h
===================================================================
--- src/platform.h      (revision 810)
+++ src/platform.h      (working copy)
@@ -205,7 +205,6 @@
                         va_list args);

    static void StrNCpy(Vector<char> dest, const char* src, size_t n);
-  static void WcsCpy(Vector<wchar_t> dest, const wchar_t* src);
    static char* StrDup(const char* str);

    // Support for profiler.  Can do nothing, in which case ticks



--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to