LGTM
http://codereview.chromium.org/11608/diff/1/3 File src/regexp-macro-assembler-ia32.cc (right): http://codereview.chromium.org/11608/diff/1/3#newcode41 Line 41: * NOTICE: This is the byte offset, not the character offset! No shouting :-) http://codereview.chromium.org/11608/diff/1/3#newcode66 Line 66: * character of the string). The remaining registers are starts out as garbage. this sentence are not parse http://codereview.chromium.org/11608/diff/1/3#newcode81 Line 81: bool ignore_case) ignore_case is unused and likely to remain so. http://codereview.chromium.org/11608/diff/1/3#newcode373 Line 373: __ dec(eax); I think dec is deprecated for performance reasons (sets only some of the flags). http://codereview.chromium.org/11608/diff/1/3#newcode499 Line 499: ASSERT(register_index >= num_saved_registers_); // Reserved for positions! We might want to use this instruction on capture positions too. http://codereview.chromium.org/11608/diff/1/3#newcode581 Line 581: __ j(above, &no_preempt, taken); This needs to be moved out of line at some point (ie in the generated code). http://codereview.chromium.org/11608 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
