http://codereview.chromium.org/11608/diff/1/3 File src/regexp-macro-assembler-ia32.cc (right):
http://codereview.chromium.org/11608/diff/1/3#newcode81 Line 81: bool ignore_case) I see that the CheckNotBackReferenceCaseIndependent method has been added. In that case there indeed isn't any need for this parameter any more. http://codereview.chromium.org/11608/diff/1/3#newcode499 Line 499: ASSERT(register_index >= num_saved_registers_); // Reserved for positions! It won't work for positions, as currently implemented. Internally, a position is stored as a negative byte index from the end of the string. You should only ever use WriteCurrentPositionToRegister to create position values. If we need to store a position, we should create WritePositionToRegister(int reg, int cp_offset) http://codereview.chromium.org/11608 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
