LGTM.
Maybe you can add a test that shows what happens if you pass in a
closure that uses local variables from its context:
var x = 3;
function (execstate) {
execstate.something == x;
}
This should just work, but a test would be nice.
http://codereview.chromium.org/12472/diff/1/4
File src/api.cc (right):
http://codereview.chromium.org/12472/diff/1/4#newcode2907
Line 2907: if (!i::V8::HasBeenSetup()) v8::Undefined();
You probably mean to return here.
http://codereview.chromium.org/12472/diff/1/6
File src/debug.cc (right):
http://codereview.chromium.org/12472/diff/1/6#newcode1670
Line 1670: Object** argv[kArgc] = { exec_state.location(),
Doesn't this fit on one line?
http://codereview.chromium.org/12472/diff/1/2
File test/cctest/test-debug.cc (right):
http://codereview.chromium.org/12472/diff/1/2#newcode3210
Line 3210: // JavaScript in the debugger.
JavaScript function.
http://codereview.chromium.org/12472/diff/1/2#newcode3276
Line 3276: v8::Script::Compile(v8::String::New("function f()
{CheckFrameCount(2)}; f()"))->Run();
Is this line too long?
http://codereview.chromium.org/12472
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
