Added a function which captures a context variable as an additional test.
http://codereview.chromium.org/12472/diff/1/4 File src/api.cc (right): http://codereview.chromium.org/12472/diff/1/4#newcode2907 Line 2907: if (!i::V8::HasBeenSetup()) v8::Undefined(); On 2008/11/26 15:02:42, Mads Ager wrote: > You probably mean to return here. Changd to return an empty handle as returning v8::Undefined() if V8 is not initialized makes no sense. Also added an ON_BAILOUT check. http://codereview.chromium.org/12472/diff/1/6 File src/debug.cc (right): http://codereview.chromium.org/12472/diff/1/6#newcode1670 Line 1670: Object** argv[kArgc] = { exec_state.location(), On 2008/11/26 15:02:42, Mads Ager wrote: > Doesn't this fit on one line? Changed. http://codereview.chromium.org/12472/diff/1/2 File test/cctest/test-debug.cc (right): http://codereview.chromium.org/12472/diff/1/2#newcode3210 Line 3210: // JavaScript in the debugger. On 2008/11/26 15:02:42, Mads Ager wrote: > JavaScript function. Changed. http://codereview.chromium.org/12472/diff/1/2#newcode3276 Line 3276: v8::Script::Compile(v8::String::New("function f() {CheckFrameCount(2)}; f()"))->Run(); On 2008/11/26 15:02:42, Mads Ager wrote: > Is this line too long? It is no more. http://codereview.chromium.org/12472 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
