Lgtm.
http://codereview.chromium.org/13088/diff/1/5 File src/regexp-delay.js (right): http://codereview.chromium.org/13088/diff/1/5#newcode318 Line 318: function RegExpGetInput() { return regExpInput || ""; } Note that this changes the behavior when input is a false-like value like false, 0 or null. Consider using IS_UNDEFINED instead. Also, do we want to distinguish between regExpInput being uninitialized and regExpInput being initialized and containing undefined? http://codereview.chromium.org/13088/diff/1/3 File test/mjsunit/mjsunit.js (right): http://codereview.chromium.org/13088/diff/1/3#newcode93 Line 93: var threw_exception = true; I believe we usually use lower camelcase in JS, lower case with underscores is for C++. http://codereview.chromium.org/13088 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
