On 2008/12/03 12:15:59, Christian Plesner Hansen wrote:
> Line 318: function RegExpGetInput() { return regExpInput || ""; }
> Note that this changes the behavior when input is a false-like value
like false,
> 0 or null. Consider using IS_UNDEFINED instead.
Done. Using IS_UNDEFINED is clearer.
> Also, do we want to distinguish between regExpInput being
uninitialized and
> regExpInput being initialized and containing undefined?
We do not have to because the setter always converts the argument to a
string. The comment in the code is wrongly stating that we do not
convert to string on assignment and I have fixed that.
> Line 93: var threw_exception = true;
> I believe we usually use lower camelcase in JS, lower case with
underscores is
> for C++.
Fixed.
http://codereview.chromium.org/13088
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
