Reviewers: Christian Plesner Hansen, Message: Bugfix review.
Description: Two tests in the Mozilla test suite pass due to a bug in the framework (compares numbers to NaN with !=). The tests should fail on V8. The tests are disabled until the framework is fixed. Please review this at http://codereview.chromium.org/12896 Affected files: M test/mozilla/mozilla.status Index: test/mozilla/mozilla.status diff --git a/test/mozilla/mozilla.status b/test/mozilla/mozilla.status index 18f5d5d59f0085a9cbfb7d302544910dd7f2b70c..fc924657fd11197c1ce0f89b73d6f03900765ad9 100644 --- a/test/mozilla/mozilla.status +++ b/test/mozilla/mozilla.status @@ -53,6 +53,15 @@ def FAIL_OK = FAIL, OKAY js1_5/Regress/regress-271716-n: SKIP +# These tests are simply wrong (i.e., they do not test what they intend +# to test). +# In particular, these two compare numbers to NaN with != in the current +# version of the Mozilla tests. This is *fixed* in a later version. +# The tests should be re-enabled when switching to a new version. +ecma_3/Date/15.9.3.2-1: SKIP +js1_2/function/Number: SKIP + + ##################### SLOW TESTS ##################### # This takes a long time to run (~100 seconds). It should only be run @@ -281,7 +290,9 @@ js1_5/Date/regress-301738-02: FAIL_OK # Semi-arbitrary limits in Date parser (date or month of 70+ is an error, # so that only one field can be interpreted as a year). We follow JSC instead. -ecma_3/Date/15.9.3.2-1: FAIL_OK +# (Currently completely skipped due to bug in Mozilla test framework that +# makes it pass). +# ecma_3/Date/15.9.3.2-1: FAIL_OK # This test fails for all browsers on in the CET timezone. @@ -578,8 +589,9 @@ js1_4/Regress/function-003: FAIL # Relies on JavaScript 1.2 / 1.3 deprecated features. js1_2/function/regexparg-1: FAIL -js1_2/function/Number: FAIL - +# (Currently completely skipped due to bug in Mozilla test framework that +# makes it pass). +# js1_2/function/Number: FAIL # 'export' and 'import' are not keywords in V8. ecma_2/Exceptions/lexical-010: FAIL --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
