Two possible changes are suggested, otherwise LGTM. My stuff will use this, so I hope it checks in.
http://codereview.chromium.org/13127/diff/28/605 File src/virtual-frame-ia32.cc (right): http://codereview.chromium.org/13127/diff/28/605#newcode358 Line 358: __ push(source.reg()); Is this now SpillElement(i)? http://codereview.chromium.org/13127/diff/28/605#newcode405 Line 405: __ push(source.reg()); Isn't this entire else block now just SpillElement(i)? http://codereview.chromium.org/13127 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
