This looks very unfinished, but at least I now see how you intend to use the Result class.
-Ivan http://codereview.chromium.org/13665/diff/1/3 File src/codegen-ia32.cc (right): http://codereview.chromium.org/13665/diff/1/3#newcode1183 Line 1183: int value, Generally I would expect the order of parameters for operation values as left to right. So you will want to change the order passing the reg before the value. http://codereview.chromium.org/13665/diff/1/3#newcode1225 Line 1225: Register r1 = allocator()->Allocate(); I do not understand why you bother loading the constant value into a register in this case. You are comparing two constants so the outcome should be determined at compile time and you can branch straight to the appropriate label. P.S. r1 is a very unlucky choice for a register variable name. I know that it does not matter for the IA32 code gen. In a sense you would have wanted to use temp_reg here, but temp was already used (and Kevin already commented on that name). http://codereview.chromium.org/13665 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
