LGTM too, with one small comment.
http://codereview.chromium.org/13665/diff/403/29 File src/virtual-frame-ia32.cc (right): http://codereview.chromium.org/13665/diff/403/29#newcode72 Line 72: return; You don't really need return from a void method here. This whole method is clearer if you add a function Result::is_valid and write: void Result::ToRegister() { ASSERT(is_valid()); if (is_constant()) { Register reg = cgen_->allocator()->Allocate(); ASSERT(reg.is_valid()); cgen_->masm()->Set(reg, Immediate(handle())); data_.reg_ = reg; type_ = REGISTER; } ASSERT(is_register()); } http://codereview.chromium.org/13665 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
