All changes made. This and 13344 are committed as revision 979. Sorry they aren't separate.
http://codereview.chromium.org/13665/diff/403/28 File src/codegen-ia32.cc (right): http://codereview.chromium.org/13665/diff/403/28#newcode1220 Line 1220: // TODO Verify that Deferred code entry and exit work properly, with frames. On 2008/12/12 18:23:03, iposva wrote: > TODO -> TODO() Done. Removed - the class checks. http://codereview.chromium.org/13665/diff/403/29 File src/virtual-frame-ia32.cc (right): http://codereview.chromium.org/13665/diff/403/29#newcode72 Line 72: return; On 2008/12/14 12:51:42, Kevin Millikin wrote: > You don't really need return from a void method here. This whole method is > clearer if you add a function Result::is_valid and write: > void Result::ToRegister() { > ASSERT(is_valid()); > if (is_constant()) { > Register reg = cgen_->allocator()->Allocate(); > ASSERT(reg.is_valid()); > cgen_->masm()->Set(reg, Immediate(handle())); > data_.reg_ = reg; > type_ = REGISTER; > } > ASSERT(is_register()); > } Done. http://codereview.chromium.org/13665/diff/403/30 File src/virtual-frame-ia32.h (right): http://codereview.chromium.org/13665/diff/403/30#newcode81 Line 81: INVALID}; On 2008/12/12 18:23:03, iposva wrote: > Closing brace on next line like in all other places in the code. Done. http://codereview.chromium.org/13665 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
