LGTM
http://codereview.chromium.org/14170/diff/1/9 File src/assembler-ia32.cc (right): http://codereview.chromium.org/14170/diff/1/9#newcode1993 Line 1993: ASSERT(pos != RelocInfo::kNoPosition); In the ARM code, RecordPosition and RecordStatementPosition called WriteRecordedPositions. Why is that not needed here (or is it not needed on ARM)? http://codereview.chromium.org/14170/diff/1/3 File src/assembler-ia32.h (right): http://codereview.chromium.org/14170/diff/1/3#newcode710 Line 710: int current_statement_position() const { return current_statement_position_; } This line looks a tiny bit too long? http://codereview.chromium.org/14170 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
