http://codereview.chromium.org/14170/diff/1/9 File src/assembler-ia32.cc (right):
http://codereview.chromium.org/14170/diff/1/9#newcode1993 Line 1993: ASSERT(pos != RelocInfo::kNoPosition); On 2008/12/17 07:45:35, Mads Ager wrote: > In the ARM code, RecordPosition and RecordStatementPosition called > WriteRecordedPositions. Why is that not needed here (or is it not needed on > ARM)? The reason for this it that on Intel we postpone the actual writing to the relocation information until the point where there can actually be a debug break. Currently it means that the positions are written whenever either a call instruction is written or when the JavaScript return relocation information record is written. The reason for postponing it on Intel was to make the peephole optimizer more efficient as it could not eliminate instructions which har relocation information attached to them. http://codereview.chromium.org/14170/diff/1/3 File src/assembler-ia32.h (right): http://codereview.chromium.org/14170/diff/1/3#newcode710 Line 710: int current_statement_position() const { return current_statement_position_; } On 2008/12/17 07:45:35, Mads Ager wrote: > This line looks a tiny bit too long? Done. http://codereview.chromium.org/14170 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
