Only one potential error found by me.
http://codereview.chromium.org/15079/diff/401/601 File src/register-allocator-ia32.cc (right): http://codereview.chromium.org/15079/diff/401/601#newcode95 Line 95: } I think we are missing the case where this.reg() is target, but target occurs multiple times in the frame. We need to spill target in that case, I think. http://codereview.chromium.org/15079/diff/401/601#newcode109 Line 109: Use(edi); Aren't we going to need to unuse edi before the ValidRegisters check at JumpTarget works? http://codereview.chromium.org/15079/diff/401/607 File src/register-allocator-ia32.h (right): http://codereview.chromium.org/15079/diff/401/607#newcode100 Line 100: // it. How can we move a result into a register that isn't spilled? Are you referring to the case that the result is already in a register? Then it isn't being moved. Otherwise, aren't we messing up the value already in the register? http://codereview.chromium.org/15079/diff/401/607#newcode199 Line 199: // necessary, or else fail and regutrn an invalid result. and return an invalid result. http://codereview.chromium.org/15079 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
